-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix System.Runtime tests for single file runner #50996
Conversation
Allows us to test the documented single file behaviors. Not adding a new `PlatformDetection` thing for this since we don't really have a way to detect single file that wouldn't end us up testing a tautology.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
string name; | ||
try | ||
{ | ||
name = Module.FullyQualifiedName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should always return <Unknown>
now, FWIW
Can the single file test driver set something in the AppContext and the dynamic checks then biggy back on it? I think building different test assemblies for single file testing is just going to cause pain. |
Yeah, but this is what we're doing because the xunit runner won't work for single file. If we ever bite the bullet and delete all of xunit except for the custom attributes as If it starts looking like we'll need this detection in other tests, I'll redo this to use AppContext. |
Allows us to test the documented single file behaviors.
Not adding a new
PlatformDetection
thing for this since we don't really have a way to detect single file that wouldn't end us up testing a tautology.