-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Implement Rdm and Dp #49737
[mono] Implement Rdm and Dp #49737
Conversation
@imhameed - I assume you will be enabling related tests as part of the follow up PR ? |
The related tests are enabled as part of this PR. |
9c8553a
to
0c643eb
Compare
The AOT cross-compilation failures are related and I am looking into them now. |
|
4019e39
to
1a4731c
Compare
Well, I thought I had fixed this in dotnet/llvm-project#103 and I thought that this had been made accessible to this repo via e64237d, but the same problem (RDM and DP not detected by the runtime) is still occurring. I don't know what to do other than trial-and-error debugging against CI, which has a multiple-hour turnaround time. |
@steveisok @akoeplinger any suggestions here ? |
I suppose I could try running virtualized Linux on the M1 mini. There's also various Android devices (like the Vivo IQOO 5G and Samsung Galaxy S20 Ultra) that appear to support asimdrdm and asimddp although I have no idea how easy it is to run a normal Linux distribution on these. |
I'll be away from my desk until April 5th. The current plan is to pick this up again when I return, and to attempt to do local debugging on an M1, where it is apparently possible to run a virtualized copy of Linux. When I have some downtime in the interim I'll also attempt doing some debugging against CI. |
1a4731c
to
4cd52a2
Compare
CoreCLR checks |
4cd52a2
to
01fe3e2
Compare
f0e3c44
to
0142125
Compare
0142125
to
af60ff0
Compare
Spent some time setting up the M1 with an arm64 Linux VM. The tests all pass locally (with LLVM AOT + LLVM JIT and without) but they still crash on CI: https://gist.github.com/imhameed/dc1cf3ca935c1cd6d366bb1b721d0a76 |
Does the CI machine support these instructions ? |
This reverts commit af60ff0.
If I did #52345 correctly, then yeah, I think so. |
I evidently did not do this correctly. Neither RDM nor DP are reported as supported by AT_HWCAP or /proc/cpuinfo: https://gist.github.com/imhameed/3095248a51d5ab5324cd06d59e8fb09b |
See #42322 and
#42280.
Tested manually on an arm64 Linux VM running on an M1 Mac Mini. Does not
enable RDM or DP when AOT-compiling the associated runtime tests; our CI
hardware doesn't support these extensions yet.