-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Use managed implementation of pbkdf2 for Android's one-shot implementation. #49314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jkoritzinsky
merged 5 commits into
dotnet:main
from
jkoritzinsky:pbkdf2-oneshot-fallback
Mar 10, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ea69c59
Use managed implementation of pbkdf2 for Android's one-shot implement…
jkoritzinsky bdf2e32
Merge branch 'main' of https://github.com/dotnet/runtime into pbkdf2-…
jkoritzinsky d9d55e9
PR feedback.
jkoritzinsky 75ae473
Switch using style and remove uneeded MSBuild conditions.
jkoritzinsky 7f7edf5
Merge branch 'main' into pbkdf2-oneshot-fallback
jkoritzinsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
...ecurity.Cryptography.Algorithms/src/Internal/Cryptography/Pbkdf2Implementation.Android.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Diagnostics; | ||
| using System.Security.Cryptography; | ||
|
|
||
| namespace Internal.Cryptography | ||
| { | ||
| internal partial class Pbkdf2Implementation | ||
| { | ||
| public static unsafe void Fill( | ||
| ReadOnlySpan<byte> password, | ||
| ReadOnlySpan<byte> salt, | ||
| int iterations, | ||
| HashAlgorithmName hashAlgorithmName, | ||
| Span<byte> destination) | ||
| { | ||
| Debug.Assert(!destination.IsEmpty); | ||
| Debug.Assert(hashAlgorithmName.Name is not null); | ||
| // Fall back to managed implementation since Android doesn't support the full Pbkdf2 APIs | ||
| // until API level 26. | ||
| using (Rfc2898DeriveBytes deriveBytes = new Rfc2898DeriveBytes( | ||
| password.ToArray(), | ||
| salt.ToArray(), | ||
| iterations, | ||
| hashAlgorithmName, | ||
| clearPassword: true, | ||
| requireMinimumSaltLength: false)) | ||
| { | ||
| byte[] result = deriveBytes.GetBytes(destination.Length); | ||
| result.AsSpan().CopyTo(destination); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.