Modify EventPipe runtime event generator to emit NULL string correctly #48879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Feb 28, 2021
jkotas
reviewed
Feb 28, 2021
josalem
approved these changes
Mar 15, 2021
stephentoub
approved these changes
Mar 17, 2021
davmason
approved these changes
Mar 22, 2021
|
@sywhang not sure if you saw or not, but this is showing up on the stale PR reports now |
|
@davmason Thanks, there was a test failure that I had to address. I'll merge after I see the CI pass. |
This was referenced Mar 23, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43089
EventPipe-generated events whose parameters are string just write nothing if it has the value NULL. ETW events on the contrary will write "NULL". The fix changes EventPipe to write
NULLstring like ETW does, not only because that's parity with ETW but also that is what the Manifest describes the event and TraceEvent can't correctly parse the event if we don't write anything there.