Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed null checks of buckets and entries in Dictionary and HashSet #48725

Closed
wants to merge 11 commits into from
Closed

Removed null checks of buckets and entries in Dictionary and HashSet #48725

wants to merge 11 commits into from

Commits on Mar 12, 2021

  1. Removed null checks of buckets and entries in Dictionary and HashSet … 

    …at the cost of some constructor performance.
    @TylerBrinkley
    TylerBrinkley committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b6f24a1 View commit details
    Browse the repository at this point in the history

  2. Fix divide by zero bug

    @TylerBrinkley
    TylerBrinkley committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    8efb22d View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Cache fast mod multiplier for divisor of 1 and internally cache an em… 

    …pty array instead of using Array.Empty<Entry>() since Entry is internal and to avoid the extra generic instantiation
    @TylerBrinkley
    TylerBrinkley committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    88c2fd6 View commit details
    Browse the repository at this point in the history

  2. Merge from main

    @TylerBrinkley
    TylerBrinkley committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    f66a439 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Fix errors. Adding the static field in Dictionary added a static cons… 

    …tructor which made a reflection lookup ambiguous. Additionally since initially empty dictionaries now gets the hashcode of the item's key it exposed an issue with mono's DefineEnum method where getting the hashcode of the ITypeIdentifier of a null name caused a NullReferenceException.
    @TylerBrinkley
    TylerBrinkley committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ac22ef9 View commit details
    Browse the repository at this point in the history

  2. Remove tabs

    @TylerBrinkley
    TylerBrinkley committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    94be5e8 View commit details
    Browse the repository at this point in the history

  3. Fix unit test by propagating the null arg check to EnumBuilder

    @TylerBrinkley
    TylerBrinkley committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    878852f View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Merge branch 'main' into dictionary-test

    @TylerBrinkley
    TylerBrinkley committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    3f8ddb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Update HashHelpers.cs

    @TylerBrinkley
    TylerBrinkley authored Apr 19, 2021
    Configuration menu
    Copy the full SHA
    6f80ec6 View commit details
    Browse the repository at this point in the history

  2. Remove trailing whitespace

    @TylerBrinkley
    TylerBrinkley committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    c750af8 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Merge branch 'main' into dictionary-test

    @TylerBrinkley
    TylerBrinkley authored Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c66581e View commit details
    Browse the repository at this point in the history