Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'AsSpan' over 'Substring' in 'System.Private.DataContractSerialization' #48274

Conversation

NewellClark
Copy link
Contributor

Fix violation found by the Prefer 'AsSpan' over 'Substring' analyzer in System.Private.DataContractSerialization (issue).

- Prefer 'AsSpan' over 'Substring' when span-based overloads are available.
@NewellClark
Copy link
Contributor Author

Just hit issue #32805. Rerunning (error log)

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub merged commit b3d7d67 into dotnet:master Feb 15, 2021
@NewellClark NewellClark deleted the fix-violation-System-Private-DataContractSerialization branch February 15, 2021 04:02
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants