Improve msg for missing libicu #47511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What, no fwlink? :) |
|
How do we normally handle fwlink ownership? It seemed like it would be easy to Bing. |
stephentoub
reviewed
Jan 27, 2021
src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Jan 27, 2021
|
@danmosemsft Ownership belongs to the division as a whole. It's primarily useful for scenarios where: (a) we can't easily describe in a single sentence what corrective measures to take; or (b) we can't localize the message itself but we can point the fwlink to a localized landing page. |
|
Apparently aka.ms is the new fwlink. Added one pointing to https://docs.microsoft.com/en-us/dotnet/core/run-time-config/globalization. |
|
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Test failures are #47561 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41350