Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] WasmApp.targets: Separate obj, and bin parts of the build process #47253

Merged
merged 15 commits into from
Jan 25, 2021

Commits on Jan 22, 2021

  1. [wasm] WasmAppBuilder - move the list of native assets, and logic out

    .. to the targets.
    
    - New property: `NativeAssets`, populated by `@(WasmNativeAsset)`
    - Remove property `MicrosoftNetCoreAppRuntimePackRidDir`
    - Also, add the `icudt.dat` file from the targets
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    81ae8b2 View commit details
    Browse the repository at this point in the history
  2. [wasm] Simplify handling of dotnet.{js,wasm}

    WasmAppBuilder has (non-obvious) logic to:
    
    1. if AOT'ing, then use the *generated* dotnet.{js,wasm};
    2. else use the one from the runtime pack
    
    This depends on Publish having copied those files from the runtime pack
    to the publish directory, and then comparing paths in the builder to
    decide which one to use.
    
    Instead, make this the intention obvious, and clear.
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    b105ba4 View commit details
    Browse the repository at this point in the history
  3. [wasm] Always get the native libs from the runtime pack (eg.libmono*)

    We were getting these from the publish directory, instead we can get
    them directly from the runtime pack.
    
    This includes icudt.dt, and dotnet.timezones.blat .
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    cb67f6f View commit details
    Browse the repository at this point in the history
  4. [wasm] MonoAOTCompiler: add OutputDir property

    .. where we can emit the generated native files. Since these files are
    meant only for generating the final `dotnet.wasm`, we don't want them to
    put them in the bin directory.
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    48eb4e0 View commit details
    Browse the repository at this point in the history
  5. [wasm] Use existing list of assemblies - @(_WasmAssemblies)

    .. instead of trying to find them in the build dir. This build directory
    will become a directory for intermediate build output in upcoming
    commits.
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    083a89c View commit details
    Browse the repository at this point in the history
  6. [wasm] Replace $(WasmMainAssemblyPath) with $(WasmMainAssemblyFileName)

    - Instead of having a special $(WasmMainAssemblyPath), and then adding
      it to the wasm assemblies ourselves
      - let the user project add all the relevant assemblies to
        `@(WasmAssembliesToBundle)`, which is usually as simple as
        `$(OutDir)\*.dll`.
    
    - This helps to simplify lot of things.
    - And we just need the main assembly filename for generating the
      run-v8.sh script.
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    06f0fce View commit details
    Browse the repository at this point in the history
  7. [wasm] Rename WasmBuildDir -> _WasmIntermediateOutputPath

    Based on the changes in previous commits, we can now remove
    `$(WasmBuildDir)`, and replace that with an internal
    `$(_WasmIntermediateOutputPath)`. This path will have all the build
    artifacts generated that aren't required in the app bundle.
    
    Earlier, we were using the publish directory for that, which resulted in
    it being littered with unncessary files, and files getting copied to the
    app bundle from unclear sources, and for non-obvious reasons.
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    3de972a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b6409c7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    96ac114 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2da853b View commit details
    Browse the repository at this point in the history
  11. [wasm] WasmTestRunner - rename TestAssembly->TestAssemblyFileName, to…

    … correctly reflect the value
    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8092f7a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e240982 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    90c0844 View commit details
    Browse the repository at this point in the history
  14. [wasm] update comments/docs

    radical committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    80aa92d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Configuration menu
    Copy the full SHA
    1429333 View commit details
    Browse the repository at this point in the history