-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] WasmApp.targets: Separate obj
, and bin
parts of the build process
#47253
Commits on Jan 22, 2021
-
[wasm] WasmAppBuilder - move the list of native assets, and logic out
.. to the targets. - New property: `NativeAssets`, populated by `@(WasmNativeAsset)` - Remove property `MicrosoftNetCoreAppRuntimePackRidDir` - Also, add the `icudt.dat` file from the targets
Configuration menu - View commit details
-
Copy full SHA for 81ae8b2 - Browse repository at this point
Copy the full SHA 81ae8b2View commit details -
[wasm] Simplify handling of dotnet.{js,wasm}
WasmAppBuilder has (non-obvious) logic to: 1. if AOT'ing, then use the *generated* dotnet.{js,wasm}; 2. else use the one from the runtime pack This depends on Publish having copied those files from the runtime pack to the publish directory, and then comparing paths in the builder to decide which one to use. Instead, make this the intention obvious, and clear.
Configuration menu - View commit details
-
Copy full SHA for b105ba4 - Browse repository at this point
Copy the full SHA b105ba4View commit details -
[wasm] Always get the native libs from the runtime pack (eg.libmono*)
We were getting these from the publish directory, instead we can get them directly from the runtime pack. This includes icudt.dt, and dotnet.timezones.blat .
Configuration menu - View commit details
-
Copy full SHA for cb67f6f - Browse repository at this point
Copy the full SHA cb67f6fView commit details -
[wasm] MonoAOTCompiler: add
OutputDir
property.. where we can emit the generated native files. Since these files are meant only for generating the final `dotnet.wasm`, we don't want them to put them in the bin directory.
Configuration menu - View commit details
-
Copy full SHA for 48eb4e0 - Browse repository at this point
Copy the full SHA 48eb4e0View commit details -
[wasm] Use existing list of assemblies - @(_WasmAssemblies)
.. instead of trying to find them in the build dir. This build directory will become a directory for intermediate build output in upcoming commits.
Configuration menu - View commit details
-
Copy full SHA for 083a89c - Browse repository at this point
Copy the full SHA 083a89cView commit details -
[wasm] Replace $(WasmMainAssemblyPath) with $(WasmMainAssemblyFileName)
- Instead of having a special $(WasmMainAssemblyPath), and then adding it to the wasm assemblies ourselves - let the user project add all the relevant assemblies to `@(WasmAssembliesToBundle)`, which is usually as simple as `$(OutDir)\*.dll`. - This helps to simplify lot of things. - And we just need the main assembly filename for generating the run-v8.sh script.
Configuration menu - View commit details
-
Copy full SHA for 06f0fce - Browse repository at this point
Copy the full SHA 06f0fceView commit details -
[wasm] Rename WasmBuildDir -> _WasmIntermediateOutputPath
Based on the changes in previous commits, we can now remove `$(WasmBuildDir)`, and replace that with an internal `$(_WasmIntermediateOutputPath)`. This path will have all the build artifacts generated that aren't required in the app bundle. Earlier, we were using the publish directory for that, which resulted in it being littered with unncessary files, and files getting copied to the app bundle from unclear sources, and for non-obvious reasons.
Configuration menu - View commit details
-
Copy full SHA for 3de972a - Browse repository at this point
Copy the full SHA 3de972aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6409c7 - Browse repository at this point
Copy the full SHA b6409c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96ac114 - Browse repository at this point
Copy the full SHA 96ac114View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da853b - Browse repository at this point
Copy the full SHA 2da853bView commit details -
[wasm] WasmTestRunner - rename TestAssembly->TestAssemblyFileName, to…
… correctly reflect the value
Configuration menu - View commit details
-
Copy full SHA for 8092f7a - Browse repository at this point
Copy the full SHA 8092f7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e240982 - Browse repository at this point
Copy the full SHA e240982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90c0844 - Browse repository at this point
Copy the full SHA 90c0844View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80aa92d - Browse repository at this point
Copy the full SHA 80aa92dView commit details
Commits on Jan 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1429333 - Browse repository at this point
Copy the full SHA 1429333View commit details