Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More arities for tuple returning zip extension method #47147

Merged
merged 10 commits into from
Jan 19, 2021

Conversation

huoyaoyuan
Copy link
Member

Closes #43702

It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jan 19, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #43702

It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.

Author: huoyaoyuan
Assignees: -
Labels:

area-System.Linq, new-api-needs-documentation

Milestone: -

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

public static MethodInfo Zip_TFirst_TSecond_TThird_3(Type TFirst, Type TSecond, Type TThird) =>
(s_Zip_TFirst_TSecond_TThird_3 ??
(s_Zip_TFirst_TSecond_TThird_3 = new Func<IQueryable<object>, IEnumerable<object>, IEnumerable<object>, IQueryable<(object, object, object)>>(Queryable.Zip).GetMethodInfo().GetGenericMethodDefinition()))
.MakeGenericMethod(TFirst, TSecond, TThird);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment saying ??= could be used to simplify this, but I see you're just following the pattern used in a bunch of other cases above. We can clean it up later.

Copy link
Member Author

@huoyaoyuan huoyaoyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR feedbacks

Co-authored-by: Stephen Toub <[email protected]>
Co-authored-by: Eirik Tsarpalis <[email protected]>
@eiriktsarpalis
Copy link
Member

Thanks for the contribution!

@eiriktsarpalis eiriktsarpalis merged commit 6fb9985 into dotnet:master Jan 19, 2021
@Logerfo
Copy link

Logerfo commented Jan 19, 2021

Thank you! In which runtime version is this feature supposed to be available?

@eiriktsarpalis
Copy link
Member

That would be released with .NET 6 next November.

@huoyaoyuan huoyaoyuan deleted the zip-tuple branch January 19, 2021 16:07
@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More arities for tuple returning zip extension method
4 participants