-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source index build step #46823
Add source index build step #46823
Conversation
Tagging subscribers to this area: @directhex Issue Details
|
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
@safern this is ready. Can you review please? |
eng/pipelines/runtime.yml
Outdated
# | ||
# Source Index Build | ||
# | ||
- template: ./source-index.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the path filters for this as well? I presume that we only need to run this if C# code is changed and only in some code paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its not difficult that would be fine. What do I put where to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add a subset here: https://github.com/dotnet/runtime/blob/master/eng/pipelines/common/evaluate-default-paths.yml#L66 and then you can condition the job based on that subset, something like this:
runtime/eng/pipelines/runtime.yml
Lines 82 to 86 in c9d1fd6
condition: >- | |
or( | |
eq(dependencies.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true), | |
eq(dependencies.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true), | |
eq(variables['isFullMatrix'], true)) |
Note that this only applies for CI, official builds doesn't filter per path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't do this without more changes in arcade. I can't change this job to depend on something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the right parameters to arcade, like dependsOn
and condition
? I'd like to avoid running this job in cases where it is not needed as we already use many resources.
We can merge as is, and follow up, but please open an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I can remove the part running this in PRs, then add the parameters to arcade, and put the PR stuff back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good plan.
No description provided.