Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source index build step #46823

Merged
merged 8 commits into from
Feb 10, 2021
Merged

Add source index build step #46823

merged 8 commits into from
Feb 10, 2021

Conversation

alexperovich
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jan 11, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: alexperovich
Assignees: alexperovich
Labels:

area-Infrastructure-mono

Milestone: -

@alexperovich
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@alexperovich
Copy link
Member Author

@safern this is ready. Can you review please?

#
# Source Index Build
#
- template: ./source-index.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the path filters for this as well? I presume that we only need to run this if C# code is changed and only in some code paths?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its not difficult that would be fine. What do I put where to do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a subset here: https://github.com/dotnet/runtime/blob/master/eng/pipelines/common/evaluate-default-paths.yml#L66 and then you can condition the job based on that subset, something like this:

condition: >-
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true),
eq(variables['isFullMatrix'], true))

Note that this only applies for CI, official builds doesn't filter per path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do this without more changes in arcade. I can't change this job to depend on something else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the right parameters to arcade, like dependsOn and condition? I'd like to avoid running this job in cases where it is not needed as we already use many resources.

We can merge as is, and follow up, but please open an issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I can remove the part running this in PRs, then add the parameters to arcade, and put the PR stuff back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan.

@alexperovich alexperovich merged commit c58b4bc into dotnet:master Feb 10, 2021
@alexperovich alexperovich deleted the sourceIndexBuild branch February 10, 2021 21:40
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants