Enable non-blittable struct returns on UnmanagedCallersOnly #45625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e JIT. Block UnmanagedCallersOnly in crossgen1 since the attribute parsing code isn't included.
jkoritzinsky
force-pushed
the
unmanaged-callers-only-valuetype-return
branch
from
07215bd
to
1b3ed1a
Compare
jkotas
reviewed
Dec 5, 2020
|
// Auto-generated message 69e114c which was merged 12/7 removed the intermediate src/coreclr/src/ folder. This PR needs to be updated as it touches files in that directory which causes conflicts. To update your commits you can use this bash script: https://gist.github.com/ViktorHofer/6d24f62abdcddb518b4966ead5ef3783. Feel free to use the comment section of the gist to improve the script for others. |
…lers-only-valuetype-return
|
This is ready for review. |
jkotas
reviewed
Dec 9, 2020
…ndle all calling convention resolution and support extensible calling conventions.
jkotas
reviewed
Dec 9, 2020
jkotas
reviewed
Dec 9, 2020
jkotas
reviewed
Dec 9, 2020
Co-authored-by: Jan Kotas <[email protected]>
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…lers-only-valuetype-return
|
Could you please resolve the conflict? |
|
Will do! |
jkotas
reviewed
Dec 14, 2020
…eded on the entry-point functions.
safern
added a commit
to safern/runtime
that referenced
this pull request
Dec 16, 2020
…otnet#45625)" This reverts commit c64861b.
|
I have been investigating a failing merge in aspnetcore, and isolated a repro by switching from runtimes 35fbaef and c64861b The only commit in this range is from this PR. Here is an example of error messages we get while running some functional tests with this runtime. All tests pass with the runtime build preceding this commit. There are other very similar ones, most related to SslStream, like "bad frame". This only happens on Linux and MacOS agents. Do you think there could be a reason for this change to be responsible? To reproduce, I cloned aspnetcore, updated the |
|
Yes there was a bug in this change that we fixed last night. The next Maestro update should have the fix. |
|
Awesome, thanks for the quick feedback |
BruceForstall
added a commit
to BruceForstall/runtime
that referenced
this pull request
Dec 17, 2020
Fix issue introduced in dotnet#45625
BruceForstall
added a commit
that referenced
this pull request
Dec 18, 2020
Fix issue introduced in #45625
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #39294 is merged, we no longer need to require a stub when we return a non-primitive value type. This PR removes that restriction, which enabled using blittable value type returns with UnmanagedCallersOnly. This PR also enables passing the calling convention from UnmanagedCallersOnly to the JIT at both runtime and during crossgen with crossgen2. This enables the UnmanagedCallersOnly entrypoint to have the correct calling convention even though the entrypoint is technically managed.
This PR blocks crossgenning UnmangedCallersOnly methods in crossgen1 because the custom attribute parsing code is not currently included in crossgen1 and I didn't want to fight to get that hooked up since we're looking at deprecating/removing crossgen1 in the .NET 6 time frame anyway.
Fixes #35928.