[browser][tests][outerloop] Standup OuterLoop ClientWebSocket tests #45470

kjpou1 · 2020-12-02T09:33:37Z

Get the websocket outerloop tests stood up to run.

Ongoing outstanding failures being looked at.

~~Some tests waiting on #44722 which have been tested against the mods and now pass with them.~~

New issue for CloseOutputAsync: #45468

~~multiple failures for:~~

System.Runtime.InteropServices.JavaScript.JSException : InvalidAccessError: Failed to execute 'close' on 'WebSocket': The code must be either 1000, or between 3000 and 4999. 1003 is neither.

~~The above appears to be an inconsistent response from WebSockets and what is returned/expected by managed client. Issue #45538~~

~~Instead of tracking with ActiveIssue moved the platform detection code and initialization into the test.~~

New issue for Close Description length: #45531 fixed here: #45536

Looking at subprotocol support specified by URI Query: See issue #45583

  fail: [out of order message from the browser]: http://127.0.0.1:58688/dotnet.js 9661 WebSocket connection to 'ws://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx?subprotocol=CustomProtocol' failed: Error during WebSocket handshake: Unexpected response code: 400
  fail: [FAIL] System.Net.WebSockets.Client.Tests.ConnectTest.ConnectAsync_PassNoSubProtocol_ServerRequires_ThrowsWebSocketException(server: ws://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)
  info: Assert.True() Failure
  info: Expected: True
  info: Actual:   False
  info:    at System.Net.WebSockets.Client.Tests.ConnectTest.ConnectAsync_PassNoSubProtocol_ServerRequires_ThrowsWebSocketException(Uri server)

subprotocols are supported via websockets options and specifying the subprotocol via the AddSubProtocol method.

cws.Options.AddSubProtocol(AcceptedProtocol);

Intermittent Uncaught RuntimeError: memory access out of bounds: Issue #45586

New issue for AbortTests with varied failure reasons: #45674 Fixed here: #45827

Part of #44666

ghost · 2020-12-02T09:33:40Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Get the websocket outerloop tests stood up to run.

Ongoing outstanding failures being looked at.

Author:	kjpou1
Assignees:	kjpou1
Labels:	`arch-wasm`, `area-System.Net`
Milestone:	-

…websocket-outerloop

- Removes the necessity of setting up a new test. - May want to go back to ActiveIssue for tracking purposes.

akoeplinger · 2020-12-07T15:00:02Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2020-12-07T15:01:12Z

Azure Pipelines successfully started running 1 pipeline(s).

…websocket-outerloop

- Removes the necessity of setting up a new test. - May want to go back to ActiveIssue for tracking purposes.

kjpou1 · 2020-12-09T12:51:37Z

/azp run outerloop

azure-pipelines · 2020-12-09T12:51:43Z

No pipelines are associated with this pull request.

kjpou1 · 2020-12-09T12:52:02Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2020-12-09T12:52:14Z

Azure Pipelines successfully started running 1 pipeline(s).

…websocket-outerloop

lewing

Looks good

src/libraries/System.Net.WebSockets.Client/tests/ClientWebSocketOptionsTests.cs

…etOptionsTests.cs Point to WebProxy support issue

lewing · 2020-12-11T02:30:28Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2020-12-11T02:30:39Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-12-11T02:32:39Z

Hello @lewing!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

[browser][tests][outerloop] Standup OuterLoop tests

e412aa9

kjpou1 added arch-wasm WebAssembly architecture area-System.Net labels Dec 2, 2020

kjpou1 requested review from lewing, marek-safar and steveisok December 2, 2020 09:33

kjpou1 self-assigned this Dec 2, 2020

kjpou1 requested review from akoeplinger and stephentoub December 2, 2020 09:36

Reference issue not PR

e5629ff

stephentoub approved these changes Dec 2, 2020

View reviewed changes

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

5acaa5e

…websocket-outerloop

kjpou1 mentioned this pull request Dec 3, 2020

[browser][websockets][tests] Tests for CloseDescription Max Length are failing #45531

Closed

Add active issue for CloseDescription failing tests

bff9bec

This was referenced Dec 3, 2020

[browser][websocket] Throw OperationCanceledException on connect #44722

Merged

[browser][websocket] Fix for Close Description validation #45536

Merged

Add active issue for failures for invalid close codes failing tests

050cc08

kjpou1 mentioned this pull request Dec 3, 2020

[browser][websockets][tests] Test failures for invalid WebSocketCloseStatus codes #45538

Closed

kjpou1 added 6 commits December 4, 2020 06:03

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

2448238

…websocket-outerloop

Add active issue for failures when specifying subprotocol by URI Query

5e54a1d

Add active issue for Uncaught RuntimeError: memory access out of bounds

4b1f4ef

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

36f6abb

…websocket-outerloop

Remove ActiveIssue and initialize with specific platform detection code

6ca3ee9

- Removes the necessity of setting up a new test. - May want to go back to ActiveIssue for tracking purposes.

Add ActiveIssue for CloseOutputAsync

9727e0f

kjpou1 mentioned this pull request Dec 7, 2020

[browser][websocket][tests] WebSocket Abort tests multiple failures #45674

Closed

Add ActiveIssue for AbortTests

e83c688

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

f5b20bf

…websocket-outerloop

kjpou1 added 3 commits December 9, 2020 05:24

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

fa2e118

…websocket-outerloop

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

6d64ad2

…websocket-outerloop

Remove ActiveIssue and initialize with specific platform detection code

366b5cd

- Removes the necessity of setting up a new test. - May want to go back to ActiveIssue for tracking purposes.

kjpou1 mentioned this pull request Dec 9, 2020

[browser][websockets][tests] Fix WebSocket Abort tests multiple failures #45827

Closed

kjpou1 added 2 commits December 9, 2020 11:55

Remove Active issue as it was fixed.

f57b60e

Add ActiveIssue for CancelTests that is part of the Abort tests changes

fa53bc3

kjpou1 marked this pull request as ready for review December 9, 2020 11:04

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

cc1e330

…websocket-outerloop

runfoapp bot mentioned this pull request Dec 10, 2020

Inability to unzip assets during build on Unix x64 #32805

Closed

lewing reviewed Dec 11, 2020

View reviewed changes

src/libraries/System.Net.WebSockets.Client/tests/ClientWebSocketOptionsTests.cs Outdated Show resolved Hide resolved

Update src/libraries/System.Net.WebSockets.Client/tests/ClientWebSock…

c7d62e8

…etOptionsTests.cs Point to WebProxy support issue

lewing approved these changes Dec 11, 2020

View reviewed changes

lewing added the auto-merge label Dec 11, 2020

kjpou1 merged commit 8cd2d30 into dotnet:master Dec 11, 2020

kjpou1 deleted the wasm-websocket-outerloop branch December 11, 2020 04:41

lewing changed the title ~~[browser][tests][outerloop] Standup OuterLoop WebSocket tests~~ [browser][tests][outerloop] Standup OuterLoop ClientWebSocket tests Dec 11, 2020

ghost locked as resolved and limited conversation to collaborators Jan 10, 2021

karelz added this to the 6.0.0 milestone Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[browser][tests][outerloop] Standup OuterLoop ClientWebSocket tests #45470

[browser][tests][outerloop] Standup OuterLoop ClientWebSocket tests #45470

kjpou1 commented Dec 2, 2020 •

edited

Loading

ghost commented Dec 2, 2020

akoeplinger commented Dec 7, 2020

azure-pipelines bot commented Dec 7, 2020

kjpou1 commented Dec 9, 2020

azure-pipelines bot commented Dec 9, 2020

kjpou1 commented Dec 9, 2020

azure-pipelines bot commented Dec 9, 2020

lewing left a comment

lewing commented Dec 11, 2020

azure-pipelines bot commented Dec 11, 2020

ghost commented Dec 11, 2020

[browser][tests][outerloop] Standup OuterLoop ClientWebSocket tests #45470

[browser][tests][outerloop] Standup OuterLoop ClientWebSocket tests #45470

Conversation

kjpou1 commented Dec 2, 2020 • edited Loading

ghost commented Dec 2, 2020

akoeplinger commented Dec 7, 2020

azure-pipelines bot commented Dec 7, 2020

kjpou1 commented Dec 9, 2020

azure-pipelines bot commented Dec 9, 2020

kjpou1 commented Dec 9, 2020

azure-pipelines bot commented Dec 9, 2020

lewing left a comment

Choose a reason for hiding this comment

lewing commented Dec 11, 2020

azure-pipelines bot commented Dec 11, 2020

ghost commented Dec 11, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

kjpou1 commented Dec 2, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.