Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][tests] Standup System.Net.WebSockets.Client.Tests in CI #44781

Merged
merged 11 commits into from
Nov 21, 2020
Merged

[browser][tests] Standup System.Net.WebSockets.Client.Tests in CI #44781

merged 11 commits into from
Nov 21, 2020

Conversation

kjpou1
Copy link
Contributor

@kjpou1 kjpou1 commented Nov 17, 2020 •
edited
Loading

Part of #44666

Outstanding for now are the tests that use LoopBack which depends on websockets and are not supported on browser. Marked the loopback issues as activeIssue - [ActiveIssue("#34690", TestPlatforms.Browser)]

Also, one marked [ActiveIssue("https://github.com/dotnet/runtime/issues/44720")] which is being looked into. #44720

@ghost
Copy link

ghost commented Nov 17, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

Part of #44666
Author: kjpou1
Assignees: -
Labels:

area-System.Net
Milestone: -

@kjpou1 kjpou1 self-assigned this Nov 17, 2020
@kjpou1 kjpou1 added the arch-wasm WebAssembly architecture label Nov 17, 2020
@kjpou1 kjpou1 marked this pull request as ready for review November 17, 2020 10:57
@runfoapp runfoapp bot mentioned this pull request Nov 17, 2020
Closed
lewing
lewing reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@lewing lewing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok after the loopback activeissue change

src/libraries/System.Net.WebSockets.Client/tests/CloseTest.cs Outdated Show resolved Hide resolved
@kjpou1
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
71068ec 
…websockets-tests
@kjpou1
Address review comments
5a776dd 
- mark the loopback issues as activeIssue - [ActiveIssue("#34690", TestPlatforms.Browser)]
stephentoub
stephentoub approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the existing comments, LGTM.

@kjpou1
Copy link
Contributor Author

kjpou1 commented Nov 20, 2020

Thanks for the catch Larry : Make browser specific failure browser specific

@lewing lewing merged commit 0a14898 into dotnet:master Nov 21, 2020
@kjpou1 kjpou1 deleted the wasm-websockets-tests branch November 23, 2020 05:51
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@lewing lewing lewing approved these changes

@MaximLipnin MaximLipnin Awaiting requested review from MaximLipnin

@steveisok steveisok Awaiting requested review from steveisok

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@kjpou1 kjpou1

Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kjpou1 @lewing @stephentoub @karelz @Dotnet-GitSync-Bot