Remove closure allocations from ServiceCollectionDescriptorExtensions #44696
Conversation
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Details
|
| { | ||
| // Already added | ||
| return; | ||
| } |
There was a problem hiding this comment.
How many times are these methods called in a typical startup? The fact that you said it's saving ~750 closures suggests it's called to add that many services, and this is O(N^2) (for each service looking at every other service already added)?
There was a problem hiding this comment.
Yep definitely is; can't get the call counts atm as Tracing in dotTrace is broken for me atm 😢
There was a problem hiding this comment.
It'd be good to understand the actual cost. While saving 750 allocations is good, I'd expect saving 250,000 interface dispatches to be better ;-)
There was a problem hiding this comment.
The service collection needs to store a dictionary and introduce a new interface to check if a service type already exists
ghost
locked as resolved and limited conversation to collaborators
Drops the closure allocations for
Func<ServiceDescriptor, Boolean>from 754 objects to 2 for startup allocations of an ASP.NET MVC appBefore
After
Contributes to #44598