-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Implement AppleSilicon FlushProcessWriteBuffers #44670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/gc DetailsIssue Details
|
|
@janvorli This compiles ... Will test further after an initial review. |
a237d7e to
0917115
Compare
0917115 to
4ee002e
Compare
|
So for the fallback to work on osx-x64, we need I'll change the minimum in this PR for now, but we may want to abandon the fallback until we officially decide to move the minimum macosx version. |
Hm, I haven't realized that. I am not sure what is our policy for updating the official minimum macOS version, but I believe we need to make that decision before getting the fallback part of the change in. |
|
OK I 'll split the osx-arm64 osx-x64 changes. |
janvorli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@janvorli Can you please ping me when the decision is made, I'm interested in that. |
|
// Auto-generated message 69e114c which was merged 12/7 removed the intermediate src/coreclr/src/ folder. This PR needs to be updated as it touches files in that directory which causes conflicts. To update your commits you can use this bash script: https://gist.github.com/ViktorHofer/6d24f62abdcddb518b4966ead5ef3783. Feel free to use the comment section of the gist to improve the script for others. |
29ad0f6 to
74f9a2f
Compare
Fixes #41993