Skip to content

Conversation

@sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Nov 13, 2020

Fixes #41993

@ghost
Copy link

ghost commented Nov 13, 2020

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Details

Issue Details
Description:
Author: sdmaclea
Assignees: sdmaclea
Labels:

arch-arm64, area-GC-coreclr, os-mac-os-x-big-sur

Milestone: [object Object]

@sdmaclea
Copy link
Contributor Author

@janvorli This compiles ... Will test further after an initial review.

@sdmaclea sdmaclea changed the title Implement AppleSilicon IPI Implement AppleSilicon FlushProcessWriteBuffers Nov 13, 2020
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Nov 18, 2020

So for the fallback to work on osx-x64, we need thread_get_register_pointer_values which requires macosx(10.14). We are currently compiling osx-x64 with set(MACOS_VERSION_MIN_FLAGS -mmacosx-version-min=10.13).

I'll change the minimum in this PR for now, but we may want to abandon the fallback until we officially decide to move the minimum macosx version.

@janvorli
Copy link
Member

So for the fallback to work on osx-x64, we need thread_get_register_pointer_values which requires macosx(10.14). We are currently compiling osx-x64 with set(MACOS_VERSION_MIN_FLAGS -mmacosx-version-min=10.13).

Hm, I haven't realized that. I am not sure what is our policy for updating the official minimum macOS version, but I believe we need to make that decision before getting the fallback part of the change in.

@sdmaclea
Copy link
Contributor Author

OK I 'll split the osx-arm64 osx-x64 changes.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@k15tfu
Copy link
Contributor

k15tfu commented Nov 29, 2020

but I believe we need to make that decision before getting the fallback part of the change in

@janvorli Can you please ping me when the decision is made, I'm interested in that.

@ViktorHofer
Copy link
Member

// Auto-generated message

69e114c which was merged 12/7 removed the intermediate src/coreclr/src/ folder. This PR needs to be updated as it touches files in that directory which causes conflicts.

To update your commits you can use this bash script: https://gist.github.com/ViktorHofer/6d24f62abdcddb518b4966ead5ef3783. Feel free to use the comment section of the gist to improve the script for others.

@sdmaclea sdmaclea merged commit 262d448 into dotnet:master Dec 17, 2020
@sdmaclea sdmaclea deleted the appleSiliconIPI branch December 17, 2020 21:07
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

osx-arm64 need an inter processor interrupt to guarantee all threads have synchronized

4 participants