-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Signing cleanup #44658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing cleanup #44658
Conversation
…ild. Remove old incremental signing infrastructure since we no longer use it.
…are now signed and our final artifacts are unsigned. Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
|
Tagging subscribers to this area: @ViktorHofer DetailsIssue Details
|
|
Looks like I've got a little more work to do relating to the hosting packages (they still use the old tooling) before I can do this. |
6185dc9 to
8048d2c
Compare
…through the old Microsoft.DotNet.Build.Tasks.SharedFramework tooling.
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
|
Updated official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=887901&view=results |
|
Looks like our build are getting NuGet rate limited again (at least my PR is). |
26aef44 to
593d1ff
Compare
|
The official build passed. I'll try to get a passing build here as well. |
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Errors are the usual errors we've been seeing with the Android runtime tests. Since this PR only affects CoreCLR and installer and the official build passed, I'm going to merge this in. |
Now that #38457 is merged in, there's more cleanup we can do of the signing infrastructure in the repo.
This PR moves the CrossOS DAC signing to be done in the CrossDac Pack job. As a result, we can remove the signing at build time and remove the signing during prepare-artifacts.
I also renamed UnsignedArtifacts->IntermediateArtifacts because some of the artifacts are signed and the final artifacts after prepare-artifacts are still unsigned now that we only support post build signing.
Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=885893&view=results