Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce StreamWriter allocation #44495

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Reduce StreamWriter allocation #44495

merged 3 commits into from
Nov 11, 2020

Commits on Nov 11, 2020

  1. Lazily-allocate StreamWriter's byte[] buffer 

    The byte[] buffer is used just when flushing to the underlying stream, to store the intermediate bytes as generated from the characters by the encoding.  Currently the byte[] buffer is allocated in the constructor, but for relatively small strings written/flushed synchronously (such as those often used with Console.Write), we can avoid the buffer entirely via stack allocation (in Flush); for all other cases, we can allocate it on demand.

(I considered using ArrayPool to rent/return in each Flush{Async} call, but opted not to in this change.  Someone could investigate that subsequently.)
    @stephentoub
    stephentoub committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1ece3d7 View commit details
    Browse the repository at this point in the history

  2. Undo use of static async helpers 

    In .NET Framework, there was a non-trivial penalty due to StreamWriter deriving from MarshalByRefObject and the impact that had on async methods accessing lifted locals on the state machine (it made them significantly more expensive).  The workaround was to make the async methods be statics and pass in all of the relevant instance state needed.  That workaround is no longer necessary on core, where MarshalByRefObjects are nops, leaving behind a workaround that is not just clunkier, but actually makes things more expensive because more state needs to be stored on the state machine objects (all of the arguments, which can instead just be accessed off of `this`).  Undo that whole change.
    @stephentoub
    stephentoub committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c6ad7fa View commit details
    Browse the repository at this point in the history

  3. Address PR feedback

    @stephentoub
    stephentoub committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    d15f8be View commit details
    Browse the repository at this point in the history