Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing XML docs to System.Security.* #44461

Merged
merged 8 commits into from
Nov 20, 2020
Merged

Add missing XML docs to System.Security.* #44461

merged 8 commits into from
Nov 20, 2020

Conversation

krwq
Copy link
Member

@krwq krwq commented Nov 10, 2020 •
edited
Loading

Contributes to: #43861

Adds missing XML docs to System.Security.*

Complemented by dotnet-api-docs PR: dotnet/dotnet-api-docs#5106

@ghost
Copy link

ghost commented Nov 10, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue meta data

Issue content: Contributes to: https://github.com//issues/43861

Adds missing XML docs to System.Security.*
Issue author: krwq
Assignees: -
Milestone: -

@krwq krwq mentioned this pull request Nov 10, 2020
Merged
@carlossanlop carlossanlop requested review from gewarren and a team November 10, 2020 18:31
carlossanlop
carlossanlop requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the full language review here to avoid doing it later.

...stem.Security.Cryptography.Algorithms/src/System/Security/Cryptography/Rfc2898DeriveBytes.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
carlossanlop
carlossanlop reviewed Nov 11, 2020
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there was also an exception that needed to be documented. I don't think I missed any others in the APIs you are documenting in this PR, but can you please double check?

...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Show resolved Hide resolved
@krwq @carlossanlop
Update src/libraries/System.Security.Cryptography.Pkcs/src/System/Sec…
9b44ddb 
…urity/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs

Co-authored-by: Carlos Sanchez <[email protected]>
@bartonjs
Copy link
Member

This looks redundant to the docs already on dotnet-api-docs... why do we have a one off effort for this one, instead of waiting for the bulk import?

@krwq
Copy link
Member Author

krwq commented Nov 13, 2020

@bartonjs APIs I documented here are not on dotnet-api-docs, I've added triple slash comments per guidelines in the issue

bartonjs
bartonjs reviewed Nov 18, 2020
View reviewed changes
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Outdated Show resolved Hide resolved
@runfoapp runfoapp bot mentioned this pull request Nov 19, 2020
Closed
@krwq
Update src/libraries/System.Security.Cryptography.Pkcs/src/System/Sec…
fc0e797 
…urity/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
@krwq krwq merged commit 58667e7 into dotnet:master Nov 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@bartonjs bartonjs bartonjs approved these changes

@gewarren gewarren Awaiting requested review from gewarren

Assignees

@krwq krwq

Labels
area-System.Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krwq @bartonjs @carlossanlop @Dotnet-GitSync-Bot