Skip to content

[mono] Turn methods with no instance access to static #43228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2020
Merged

[mono] Turn methods with no instance access to static #43228

merged 2 commits into from
Oct 13, 2020

Conversation

@marek-safar
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Oct 9, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@CoffeeFlux
Copy link
Contributor

Are there any plans for a CoreCLR equivalent to this? Looking at things like AppendStackFrameWithoutMethodBase, the same change could be applied there as well.

CoffeeFlux
CoffeeFlux reviewed Oct 9, 2020
View reviewed changes
src/mono/netcore/System.Private.CoreLib/src/System/Array.Mono.cs
[MethodImplAttribute(MethodImplOptions.InternalCall)]
private extern void SetValueRelaxedImpl(object? value, int pos);

#pragma warning disable CA1822
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these different? Is it just the volume and number of callers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are accessed as instance calls from JIT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like InternalArray__ICollection_get_Count, InternalArray__IReadOnlyCollection_get_Count and few others which are accessing class members do not need the suppression.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is to indicate that none of the methods should be made static even if they could

CoffeeFlux
CoffeeFlux approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@CoffeeFlux CoffeeFlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is worth addressing, but otherwise looks good to me. Thanks!

@marek-safar marek-safar merged commit 385a0c6 into dotnet:master Oct 13, 2020
@marek-safar marek-safar deleted the analyzers branch October 13, 2020 17:37
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@EgorBo EgorBo Awaiting requested review from EgorBo

@steveisok steveisok Awaiting requested review from steveisok

@vargaz vargaz Awaiting requested review from vargaz

2 more reviewers

@am11 am11 am11 left review comments

@CoffeeFlux CoffeeFlux CoffeeFlux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marek-safar @CoffeeFlux @am11 @Dotnet-GitSync-Bot