DataContractSerialization doesn't work with TrimMode - link #42824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataContractSerialization has some Reflection "shim" methods that the ILLinker can't see through. This causes critical methods to be trimmed and applications to fail. These methods were put in place in .NET Core 1.0 when the full Reflection API wasn't available. The fix is to remove these "shim" Reflection APIs and use Reflection directly. Fix dotnet#41525 Fix dotnet#42754
eerhardt
requested review from
marek-safar,
vitek-karas,
HongGit,
MichalStrehovsky and
StephenMolloy
eerhardt
commented
Sep 28, 2020
src/libraries/System.Runtime.Serialization.Xml/tests/TrimmingTests/EndToEndTest.cs
Show resolved
Hide resolved
jkotas
reviewed
Sep 29, 2020
| @@ -38,7 +38,7 @@ private static MethodInfo ObjectEquals | |||
| { | |||
| if (s_objectEquals == null) | |||
| { | |||
| s_objectEquals = Globals.TypeOfObject.GetMethod("Equals", BindingFlags.Public | BindingFlags.Static); | |||
| s_objectEquals = typeof(object).GetMethod("Equals", BindingFlags.Public | BindingFlags.Static); | |||
There was a problem hiding this comment.
It would be nice to delete Globals.TypeOfObject and all other typeof caches from the Globals type.
There was a problem hiding this comment.
Agreed. I've opened #42861 to do this.
jkotas
approved these changes
Sep 29, 2020
|
@HongGit @StephenMolloy @mconnew - thoughts on this? I'd like to propose this to be backported to 5.0 since it blocks any usage of DataContractSerializer in trimmed applications like Blazor WASM. |
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/280964515 |
mconnew
approved these changes
Sep 30, 2020
|
@eerhardt I'm seeing failures building master across the board from this PR. There's a number of trim analysis warnings due to this PR. |
eerhardt
added a commit
to eerhardt/runtime
that referenced
this pull request
Sep 30, 2020
Changes dotnet#40691 and dotnet#42824 conflicted. One added a new ILLink suppress warnings file, while the other added more warnings. This causes the build to break. The fix is to regenerate the suppressions file with the latest code. Fix dotnet#42926
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataContractSerialization has some Reflection "shim" methods that the ILLinker can't see through. This causes critical methods to be trimmed and applications to fail. These methods were put in place in .NET Core 1.0 when the full Reflection API wasn't available.
The fix is to remove these "shim" Reflection APIs and use Reflection directly.
Fix #41525
Fix #42754