Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-rc2] Update intellisense package version to RC2 #42221

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 14, 2020

Backport of #42220 to release/5.0-rc2

/cc @safern

Customer Impact

This helps customers to have the right documentation on intellisense when using VSCode or VS and looking at the API information.

Testing

Manual and visual testing done by @carlossanlop

Risk

Low. This just updates the .xml files that we ship as part of the Ref pack.

@safern
Copy link
Member

safern commented Sep 14, 2020

cc: @ericstj @danmosemsft @jeffhandley

@jeffhandley
Copy link
Member

I'll send this to tactics for Tell Mode

@jeffhandley jeffhandley added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 14, 2020
eng/Versions.props Outdated Show resolved Hide resolved
eng/Versions.props Outdated Show resolved Hide resolved
@jeffhandley
Copy link
Member

Thanks, @carlossanlop and @safern. Tactics was informed this was coming through Tell Mode earlier this week. Feel free to merge when it's ready.

@jeffhandley jeffhandley added the Servicing-approved Approved for servicing release label Sep 24, 2020
@safern safern removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 24, 2020
@safern
Copy link
Member

safern commented Sep 24, 2020

Failures are unrelated.

@safern safern merged commit 16ad84f into release/5.0-rc2 Sep 24, 2020
@safern safern deleted the backport/pr-42220-to-release/5.0-rc2 branch September 24, 2020 13:55
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants