Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build globalization lib #42166

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Build globalization lib #42166

merged 2 commits into from
Oct 12, 2020

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented Sep 12, 2020

No description provided.

@ghost
Copy link

ghost commented Sep 12, 2020

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

@VSadov
Copy link
Member Author

VSadov commented Oct 11, 2020

It looks like CoreRT does not need this at the moment. Since there are no other uses, I'll close the PR.

@VSadov VSadov closed this Oct 11, 2020
@jkotas
Copy link
Member

jkotas commented Oct 11, 2020

I do like this change as a cleanup. It makes System.Globalization built the same way as all other System.*. If you reopen this PR, I will be happy to approve it.

@jkotas jkotas reopened this Oct 11, 2020
@jkotas
Copy link
Member

jkotas commented Oct 12, 2020

Passed OSX CI before

@jkotas jkotas merged commit bcc8412 into dotnet:master Oct 12, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants