Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM #42010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley |
MaximLipnin
force-pushed
the
crypto_unsupported_on_browser
branch
3 times, most recently
from
ac338f2
to
3723b99
Compare
71 tasks
MaximLipnin
force-pushed
the
crypto_unsupported_on_browser
branch
from
3723b99
to
c38a6e2
Compare
|
I think |
@vcsjones Thanks, addressed |
mdh1418
reviewed
Sep 9, 2020
...aries/System.Security.Cryptography.Algorithms/ref/System.Security.Cryptography.Algorithms.cs
Show resolved
Hide resolved
mdh1418
reviewed
Sep 9, 2020
...aries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/HMACSHA256.cs
Outdated
Show resolved
Hide resolved
mdh1418
approved these changes
Sep 9, 2020
My understanding is that MD5 support was removed and won't be supported in Browser. #40486 (comment). |
bartonjs
reviewed
Sep 9, 2020
...y.Cryptography.Algorithms/src/System/Security/Cryptography/AsymmetricKeyExchangeFormatter.cs
Show resolved
Hide resolved
bartonjs
reviewed
Sep 9, 2020
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/DSA.cs
Show resolved
Hide resolved
bartonjs
reviewed
Sep 9, 2020
...braries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/HMACSHA1.cs
Show resolved
Hide resolved
Seems that I was confused by the browser api exclusion list containing MD5 type and including it to the build for browser target. |
|
@bartonjs I'll fix those style issues |
kjpou1
reviewed
Sep 11, 2020
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/RC2.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Sep 11, 2020
kjpou1
approved these changes
Sep 11, 2020
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Sep 15, 2020
…r WASM (dotnet#42010) * Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM * Address the comment regarding IncrementalHash.CreateHMAC * Group System.* usings * Restore the blank lines between the meta-comment and the code for all the HMAC classes * Fix style issues * Mark MD5 class as unsupported on Browser; clean up the api exclusion list and proj file. * Using * Style fix
lewing
pushed a commit
that referenced
this pull request
Sep 16, 2020
…hanges (#42267) * Mark System.IO.Pipes Unsupported at assembly level (#41976) Co-authored-by: Mitchell Hwang <[email protected]> * Mark some System.Net.Http APIs as unsupported on browser (#42074) * Mark some System.Net.HttpListener APIs as unsupported on browser (#42063) * Mark some System.Net.HttpListener APIs as unsupported on browser * FIx windows builds * Fix windows builds * Remove browser annotations from the properties with windows-specific setters. * Mark only setter of ExtendedProtectionPolicy * Remove another redundant annotation * Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM (#42010) * Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM * Address the comment regarding IncrementalHash.CreateHMAC * Group System.* usings * Restore the blank lines between the meta-comment and the code for all the HMAC classes * Fix style issues * Mark MD5 class as unsupported on Browser; clean up the api exclusion list and proj file. * Using * Style fix Co-authored-by: Mitchell Hwang <[email protected]> Co-authored-by: Maxim Lipnin <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some types from
System.Security.Cryptography.Algorithmswhich are supported on Browser:Others throw PNSE and can be marked as unsupported.
Part of #41087