-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK min and target version to >= Preview8 #41947
Conversation
Update the SDK min version to Preview 8 final and update the target version to RC.1 latest.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
This reverts commit b313c2f.
Merging as all other legs already passed in the previous run and the allconfigurations now succeeded as well. |
@ViktorHofer @dotnet/runtime-infrastructure It looks like this change broke coreclr outerloop testing: https://dev.azure.com/dnceng/public/_build/results?buildId=809051&view=results Which means all pri-1 testing will fail |
I believe @jkoritzinsky was taking a look at this? |
Yep I'm looking at this today. |
@jkoritzinsky Are you still looking? Every test leg is failing this weekend. |
#42146 will fix it, but it hasn't been merged in yet. |
OK, let me put out the PR for disabling the one test for now in issues.targets to unblock the pipeline. |
I guess the interesting question is when the PR can be realistically merged in. If that's just around the bend, blocking the test out would cause more churn than good, but if we only get to it on Tuesday, it will be a grim Thursday at the CI council meeting ;-). |
I opened #42168 to track this. btw, it looks like there are many thousands of warnings in the test build that I don't remember seeing before. |
I asked about that on the internal infra e-mail alias and my understanding is that this is due to some more stringent checks in new Roslyn. Which is an interesting question, perhaps @jaredpar may have thoughts on what is the preferable way forward - either booking the time to clean the tests up to conform with the latest compiler version, or treating them as "set in stone" (which may be more appropriate e.g. for various regression tests) and maybe devising a new way to mark newly added tests as (potentially) conforming to a more stringent warning policy employed by the newest C# compiler. |
Hmm, my bad, it's not as easy as blocking the test out in |
* Update SDK min and target version to >= Preview8
Update the SDK min version to Preview 8 final and update the target version to RC.1 latest.
Fixes #38902