Replace g_tkCorEncodeToken with CorSigDecodeTokenType() inline function to keep its definition in cor.h #41797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Sep 3, 2020
…on to keep its definition in cor.h Fixes undefined references to g_tkCorEncodeToken when using CorSigCompressToken() in user projects with shared Profiling API headers like cor.h / corprof.h See dotnet#40254 (comment).
k15tfu
force-pushed
the
fix-undef-refs-g_tkCorEncodeToken-cor.h
branch
from
9e78313
to
e856dca
Compare
k15tfu
changed the title
jkotas
reviewed
Sep 3, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap g_tkCorEncodeToken into inline function to keep its definition in cor.h
Fixes undefined references to g_tkCorEncodeToken when using CorSigCompressToken()
in user projects with shared Profiling API headers like cor.h / corprof.h
See #40254 (comment).
cc @janvorli @jkotas