Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-rc2] Remove System.Net.Connections and related features (#41648) #41726

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

geoffkizer
Copy link
Contributor

@geoffkizer geoffkizer commented Sep 2, 2020

Backport to 5.0-rc2. Approved in tactics this morning.

Original PR: #41648

* remove System.Net.Connections and related features

* cleanup csproj changes

* Update src/libraries/pkg/baseline/packageIndex.json

Co-authored-by: Cory Nelson <[email protected]>

* Update src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs

Co-authored-by: Cory Nelson <[email protected]>

Co-authored-by: Geoffrey Kizer <[email protected]>
Co-authored-by: Cory Nelson <[email protected]>
@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@geoffkizer
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geoffkizer geoffkizer added this to the 5.0.0 milestone Sep 2, 2020
@scalablecory scalablecory changed the title Remove System.Net.Connections and related features (#41648) [release/5.0-rc2] Remove System.Net.Connections and related features (#41648) Sep 2, 2020
@geoffkizer geoffkizer merged commit 3609f05 into dotnet:release/5.0-rc2 Sep 2, 2020
@geoffkizer geoffkizer deleted the port41648to50-rc2 branch November 7, 2020 23:40
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants