Add runtimelab.yml for dotnet/runtimelab experiments CI and build infrastructure #39749
Conversation
| @@ -203,7 +203,7 @@ | |||
|
|
|||
| <!-- Installer sets --> | |||
| <ItemGroup Condition="$(_subset.Contains('+corehost+'))"> | |||
| <CorehostProjectToBuild Include="$(InstallerProjectRoot)corehost\build.proj" SignPhase="Binaries" /> | |||
| <CorehostProjectToBuild Include="$(InstallerProjectRoot)corehost\corehost.proj" SignPhase="Binaries" /> | |||
There was a problem hiding this comment.
The reason why this project needs to be renamed is because we discovered that the project.assets.json file for this installer build.proj clashed with the repo's root build.proj, causing restore issues and overrides whenever the installer subset was being built. This will fix that issue. Kudos for finding the issue to @safern and @ViktorHofer
| @@ -4,6 +4,7 @@ | |||
| <PropertyGroup> | |||
| <TraversalGlobalProperties>BuildAllProjects=true</TraversalGlobalProperties> | |||
| <AdditionalBuildTargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">$(AdditionalBuildTargetFrameworks);package-$(Configuration)</AdditionalBuildTargetFrameworks> | |||
| <BuildAllOOBPackages Condition="'$(BuildAllOOBPackages)' == ''">true</BuildAllOOBPackages> | |||
There was a problem hiding this comment.
is that property set to a different value anywhere yet?
There was a problem hiding this comment.
Yup, this is set to false already on one of our experiments in the runtimelab repo and it will be added to the rest as well:
https://github.com/dotnet/runtimelab/blob/Utf8String/src/libraries/libraries-packages.proj#L7
Also the idea of this property is that it would be used once we turn up the crank for servicing as the way to disable all packages build that are not specifically marked as build.
|
Merging as the previous commit was all green and last change was just a minor file rename so no need to rerun CI. thanks for the reviews. |
…rastructure (dotnet#39749) * Add runtimelab.yml for dotnet/runtimelab experiments CI and build infrastructure * rename one of the ymls based on feedback
ghost
locked as resolved and limited conversation to collaborators
cc: @safern @jkotas @ericstj
This is adding the infrastructure that has already been added to the Utf8String experiment in runtimelab which already has CI coverage. The idea of adding this infra back into dotnet/runtime is that future experiments in runtimelab will just get this infra for free and the diff between the experiment on runtimelab and dotnet/runtime is actually only experiment-specific code and it is easy to merge back to dotnet/runtime when ready.