Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply arm64 intrinsics to System.Text.Encodings.Web #38707

Merged
merged 32 commits into from
Jul 15, 2020
Merged

Apply arm64 intrinsics to System.Text.Encodings.Web #38707

merged 32 commits into from
Jul 15, 2020

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jul 2, 2020 •
edited
Loading

No description provided.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Tagging subscribers to this area: @tarekgh
Notify danmosemsft if you want to be subscribed.

@eiriktsarpalis eiriktsarpalis removed the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 2, 2020
@eiriktsarpalis eiriktsarpalis added this to the 5.0.0 milestone Jul 2, 2020
@tarekgh
Copy link
Member

tarekgh commented Jul 2, 2020

CC @GrabYourPitchforks

@eiriktsarpalis eiriktsarpalis changed the title [WIP] Apply arm64 intrinsics to System.Text.Encodings.Web Apply arm64 intrinsics to System.Text.Encodings.Web Jul 7, 2020
@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review July 7, 2020 20:17
@safern safern mentioned this pull request Jul 8, 2020
Closed
carlossanlop
carlossanlop reviewed Jul 9, 2020
View reviewed changes
...ibraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoder.cs Outdated Show resolved Hide resolved
...ystem.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoderBasicLatin.cs Show resolved Hide resolved
...ibraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoder.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/TextEncoder.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/TextEncoder.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/AdvSimdHelper.cs Outdated Show resolved Hide resolved
@jeffhandley jeffhandley requested a review from pgovind July 9, 2020 19:34
@kunalspathak
Copy link
Member

@eiriktsarpalis - Can you also share the performance improvements you get?

@eiriktsarpalis
Copy link
Member Author

Can you also share the performance improvements you get?

There seems to be no performance suite for the particular library. Would probably need to write one up and compare.

@eiriktsarpalis
Copy link
Member Author

CI failures are unrelated test failures, merging away.

@eiriktsarpalis eiriktsarpalis merged commit cd8759d into dotnet:master Jul 15, 2020
@eiriktsarpalis eiriktsarpalis deleted the vectorize-encodings-web branch July 15, 2020 14:50
@kunalspathak kunalspathak mentioned this pull request Jul 15, 2020
Merged
@eiriktsarpalis eiriktsarpalis mentioned this pull request Jul 16, 2020
Closed
@ericstj ericstj mentioned this pull request Jul 16, 2020
Closed
@eiriktsarpalis eiriktsarpalis mentioned this pull request Jul 23, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TamarChristinaArm TamarChristinaArm TamarChristinaArm left review comments

@kunalspathak kunalspathak kunalspathak approved these changes

@tarekgh tarekgh tarekgh left review comments

@tannergooding tannergooding tannergooding approved these changes

@carlossanlop carlossanlop carlossanlop left review comments

@echesakov echesakov Awaiting requested review from echesakov

@pgovind pgovind Awaiting requested review from pgovind

Assignees
No one assigned
Labels
arch-arm64 area-System.Text.Encodings.Web
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
9 participants
@eiriktsarpalis @tarekgh @kunalspathak @carlossanlop @echesakov @pgovind @tannergooding @TamarChristinaArm @Dotnet-GitSync-Bot