Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add Reverse Diagnostics Server" #35767

Merged
merged 1 commit into from
May 3, 2020
Merged

Revert "Add Reverse Diagnostics Server" #35767

merged 1 commit into from
May 3, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 3, 2020 •
edited
Loading

Reverts #33307

Fixes #35451

@ghost
Copy link

ghost commented May 3, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jkotas jkotas mentioned this pull request May 3, 2020
Closed
@jkotas jkotas merged commit 7a95cc8 into master May 3, 2020
@safern
Copy link
Member

safern commented May 3, 2020

Thanks @jkotas. Will keep an eye on the rolling builds and PRs to bring our pass rate up again.

@jkotas jkotas deleted the revert-33307-dev/josalem/diag-server-handshake branch May 5, 2020 04:17
@jaredpar jaredpar mentioned this pull request May 5, 2020
Closed
josalem pushed a commit to josalem/runtime that referenced this pull request May 7, 2020
Revert "Revert "Add Reverse Diagnostics Server (dotnet#33307)" (dotne…
e623063 
…t#35767)"

This reverts commit 7a95cc8.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test hang in System.Diagnostics.Tracing.EventProvider.EventUnregister
3 participants
@jkotas @safern @Dotnet-GitSync-Bot