Remove Pure attribute from System.Collections.Immutable

[ericstj]

No description provided.

[ghost]

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

[ericstj]

Fixes #28488

[ericstj]

Tagged as breaking since the issue mentions that the purpose of this is to raise CA1806 warnings.

[ericstj]

So I changed the title of this PR to remove the usage of Pure. @AArnott / @stephentoub what do you think is the right way to track the scenario here?

[stephentoub]

what do you think is the right way to track the scenario here?

First decide what the scenario is 😄 If it's "warn when methods whose results shouldn't be ignored are ignored", we should have an issue tracking/designing it (I think @terrajobst already opened one somewhere for that). If the scenario is something else, well, same answer :)

[ericstj]

First decide what the scenario is 😄 If it's "warn when methods whose results shouldn't be ignored are ignored", we should have an issue tracking/designing it (I think @terrajobst already opened one somewhere for that). If the scenario is something else, well, same answer :)

Well I was expecting @AArnott to help fill that in once we have some direction about where to do so. I imagine the one you described is close enough to what I'm imagining @AArnott is looking for. @terrajobst can you link us up with that issue?

[terrajobst]

I imagine the one you described is close enough to what I'm imagining @AArnott is looking for. @terrajobst can you link us up with that issue?

That would be #34098. Based on the experience of @stephentoub & @jaredpar in Midori I'd say the direction of having an attribute like [DoNotIgnoreReturnValue] seems like the right direction.