Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoreLib shared paths in coreclr #34

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Fix CoreLib shared paths in coreclr #34

merged 1 commit into from
Nov 14, 2019

Conversation

ViktorHofer
Copy link
Member

No description provided.

@ViktorHofer ViktorHofer self-assigned this Nov 14, 2019
trylek
trylek approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ViktorHofer ViktorHofer merged commit b2a903f into dotnet:master Nov 14, 2019
@ViktorHofer ViktorHofer deleted the CoreLibPathFixes branch November 14, 2019 14:08
@jbatt33 jbatt33 mentioned this pull request Feb 5, 2020
Merged
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
layomia pushed a commit to layomia/dotnet_runtime that referenced this pull request Nov 10, 2020
@kevinwkt
Merge pull request dotnet#34 from kevinwkt/TypeWrapperAssemblyMetadat…
efc134e 
…aFix

Add typewrapper tests after fixing metadataloadcontext issue
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @trylek @karelz