.NET Core to .NET branding changes #33694
Conversation
jkotas
requested review from
ahsonkhan,
akoeplinger,
EgorBo,
jozkee,
lateralusX,
layomia,
marek-safar,
steveharter,
steveisok and
vargaz
as code owners
|
This renames about 1/3 of all .NET Core references in the repo to just .NET. I have made sure that all user visible strings are renamed. The remaining instances are in docs or comments, and renaming them to just .NET would often be confusing, e.g. when they refer to specific version or difference against .NET Framework. |
|
Marking as breaking change. This can break code that checks for ".NET Core" in framework description, etc. |
jkotas
added
the
breaking-change
|
Depends on dotnet/arcade#5086 |
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "maintainer_name":".NET Core Team", | |||
| "maintainer_name":".NET Team", | |||
| "maintainer_email": "[email protected]", | |||
There was a problem hiding this comment.
The email is for [email protected] and the name is .NET Team. Should the name be .NET Foundation or something like that?
There was a problem hiding this comment.
This was introduced in dotnet/core-setup#2525 . @richlander Is there anything to fix?
There was a problem hiding this comment.
".NET Team" looks good to me as the "maintainer".
| @@ -172,7 +172,7 @@ To install dotnet symbol issue the command | |||
| ``` | |||
| dotnet tool install -g dotnet-symbol | |||
| ``` | |||
| With that installed download the symbols to a local directory. if your installed version of the .NET Core runtime is | |||
| With that installed download the symbols to a local directory. if your installed version of the .NET runtime is | |||
| 2.1.0 the command to do this is | |||
There was a problem hiding this comment.
This tracing documentation is spread over multiple places. I believe it would be best to delete this doc, and centralize the documentation on the official docs site. I have opened dotnet/diagnostics#933 on it.
|
Blocked by dotnet/BenchmarkDotNet#1399 |
ghost
locked as resolved and limited conversation to collaborators
Contributes to #33680