-
Couldn't load subscription status.
- Fork 5.2k
Annotate System.Net.Http for nullable #33268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What's going to happen when then the changes in the shared files sync to aspnetcore which does not use nullable? Please have someone try it before merging this. |
By default we are enabling nullability on project level and if there is any shared file which failing other projects because of a
Please let me know who could help with that and/or give us the list of referenced files, then I can check them and add |
...raries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpContentWriteStream.cs
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/NameValueHeaderValue.cs
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/DelegatingHandler.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/ProductInfoHeaderValue.cs
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/ViaHeaderValue.cs
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/WarningHeaderValue.cs
Show resolved
Hide resolved
|
/azp list |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Other than addressing feedback, due to the large number of asserts being added, could you please ensure that outerloop tests are working as expected?
Sure i can run outerloop, JFYI i was able to run only Didn't run and don't know how to run |
@Tratcher this PR pretty close to be merged, who from aspnetcore team could try this out before merge? |
|
Sorry, I've been OOF. I can give this a try today. |
Thanks, please let me know if something fail, otherwise this PR is good to go |
|
@dotnet/ncl if you have a PR updating this API please pull and build first to avoid build failure in repo, even if you are not seeing conflict or build error on your branch |
Contributes to #2339
CC @dotnet/ncl