[Mono] Implement missing Sse2 intrinsics #33056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorBo
requested review from
alexischr,
CoffeeFlux,
lambdageek,
lewurm,
SamMonoRT and
vargaz
as code owners
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
EgorBo
added
area-Codegen-LLVM-mono
and removed
area-CodeGen-coreclr
EgorBo
commented
Mar 2, 2020
| @@ -83,6 +83,8 @@ METHOD(Or) | |||
| METHOD(LoadAlignedVector128) | |||
| METHOD(Xor) | |||
| METHOD(CompareGreaterThan) | |||
| METHOD(ConvertScalarToVector128UInt32) | |||
| METHOD(ConvertScalarToVector128UInt64) | |||
| METHOD(PackUnsignedSaturate) | |||
There was a problem hiding this comment.
ConvertToUInt32 and ConvertToUInt64 already exist (for Vector<T>) here.
vargaz
approved these changes
Mar 2, 2020
CoffeeFlux
approved these changes
Mar 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we only implement intrinsics used by corlib internally to optimize code.
Fixes #32510 crash.
ConvertScalarToVector128UInt32/64is expanded into LLVM'sinsertelementConvertToUInt32/64is expanded into LLVM'sextractelement