Set GenFacadesForceZeroVersionSeeds for all shims #33052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joperezr
approved these changes
Mar 2, 2020
|
I did diff this when I made the arcade change. I'll rebuild and share a diff with the latest. Looks like APICompat isn't happy with the new shims, I may need to investigate that. |
|
Here's the diffs of mscorlib between 2.1 -> latest and 3.1 -> latest. |
ericstj
force-pushed
the
shims-GenFacadesForceZeroVersionSeeds
branch
from
1403442
to
819853c
Compare
|
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
First I'd like to let this ship in a preview in 5.0, once we have confirmed it's ok we can port to servicing. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opts into GenFacadesForceZeroVersionSeeds for all shims. This is consistent with what we did in 2.x.
I've manually updated GenFacades rather than wait for #32858