Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][xunit tests] Move skipped tests out of rsp file #2087

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
d464af7
[xunit tests][mono] Remove disabled Microsoft.VisualBasic.Core.Tests …
MaximLipnin Jan 23, 2020
de634c5
[xunit tests][mono] Remove System.Collections.Specialized.Tests.Ctor_…
MaximLipnin Jan 23, 2020
d1d6386
Remove System.Collections.Concurrent.Tests.ConcurrentQueueTests.Refer…
MaximLipnin Jan 23, 2020
62a31f4
Remove BasicEventSourceTests.TestsManifestNegative.Test_GenerateManif…
MaximLipnin Jan 23, 2020
1b21ae4
Remove ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolut…
MaximLipnin Jan 23, 2020
f63488b
Remove System.IO.Tests.*.CopyFileWithData_MemberData from rsp file
MaximLipnin Jan 23, 2020
5c9e2c2
Move a set of skipped System.Linq.Expressions.Tests out of rsp file.
MaximLipnin Jan 23, 2020
8b7f4a7
Annotate System.Collections.Concurrent.Tests.ConcurrentQueueTests.Ref…
MaximLipnin Jan 24, 2020
870a16a
Move another set of skipped System.Linq.Expressions.Tests out of rsp …
MaximLipnin Jan 24, 2020
fa9dfb5
Move skipped System.Linq.Parallel.Tests.PlinqModesTests.WithExecution…
MaximLipnin Jan 24, 2020
9c6144d
Move skipped System.Memory.Tests out of rsp file
MaximLipnin Jan 24, 2020
43f57d8
Move skipped System.Net.Http.Functional.Tests.PlatformHandler_HttpCli…
MaximLipnin Jan 24, 2020
46cc919
Remove System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterfa…
MaximLipnin Jan 24, 2020
310b879
Move System.Reflection tests with an active issue out of rsp file
MaximLipnin Jan 24, 2020
81f97fc
Move skipped System.Runtime.InteropServices.Tests out of rsp file
MaximLipnin Jan 24, 2020
b705010
Replace closed CoreFX GH issue with the active Runtime one
MaximLipnin Jan 24, 2020
f444ffb
Move skipped System.Runtime.Serialization.Formatters.Tests out of rsp…
MaximLipnin Jan 24, 2020
3311ccc
Move skipped System.Runtime.Tests with an active issue out of rsp file
MaximLipnin Jan 24, 2020
d911dad
Move skipped System.Threading.Tests with an active issue out of rsp file
MaximLipnin Jan 27, 2020
b278278
Remove skipped System.Data.Common.Tests because the related issue was…
MaximLipnin Jan 27, 2020
3aa460e
Move skipped System.Data.Common.Tests.DbConnectionTests.ProviderFacto…
MaximLipnin Jan 27, 2020
e1a4e85
Move skipped System.Diagnostics.StackTrace.Tests with an active issue…
MaximLipnin Jan 27, 2020
920d42d
Move skipped System.Numerics.Vectors.Tests with an active issue out o…
MaximLipnin Jan 27, 2020
07722f1
Move skipped System.Reflection.Context.Tests with an active issue out…
MaximLipnin Jan 27, 2020
5d3788e
Move skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMi…
MaximLipnin Jan 27, 2020
288b12d
Move skipped System.ComponentModel.Composition and Tests.Integration …
MaximLipnin Jan 28, 2020
e146c57
Update a message in skipped System.Runtime.InteropServices.Tests
MaximLipnin Jan 28, 2020
d9cd430
Move skipped System.Reflection.Tests.MetadataTokenTests.SuccessImplie…
MaximLipnin Jan 28, 2020
fd2b05f
Move skipped/no repro System.Threading.Overlapped.Tests with an activ…
MaximLipnin Jan 28, 2020
d0c9bd7
Move skipped System.Runtime.Extensions with an active issue out of rs…
MaximLipnin Jan 28, 2020
a0c84bf
Re-enable skipped System.Runtime.Handles.Tests because the related is…
MaximLipnin Jan 28, 2020
8612c52
Move skipped System.Reflection.TypeExtensions.Tests with an active is…
MaximLipnin Jan 28, 2020
bab4de6
Move skipped System.Reflection.Emit.Lightweight.Tests with an active …
MaximLipnin Jan 28, 2020
90e0f05
Move skipped System.Reflection.MetadataLoadContext.Tests with an acti…
MaximLipnin Jan 28, 2020
8fc9fc8
Move skipped System.Xml.Xsl.XslTransformApi.Tests with an active issu…
MaximLipnin Jan 28, 2020
fc5784f
Move skipped System.Security.Cryptography.Encoding.Tests with an acti…
MaximLipnin Jan 28, 2020
3d0e18f
Move System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix…
MaximLipnin Jan 29, 2020
110dd50
Add an active issue attribute to System.Drawing.Imaging.Tests.ImageAt…
MaximLipnin Jan 29, 2020
9c845ef
Move System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHa…
MaximLipnin Jan 29, 2020
5b9f525
Remove System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClient…
MaximLipnin Jan 29, 2020
798166e
Move skipped System.Reflection.Emit.ILGeneration.Tests with an active…
MaximLipnin Jan 30, 2020
5bb95df
Move skipped System.Reflection.Emit.Tests with an active issue out of…
MaximLipnin Jan 30, 2020
fd36223
Remove skipped System.Reflection.Tests from rsp file because they pas…
MaximLipnin Jan 31, 2020
30b1399
Try to re-enabled skipped System.Reflection.Tests.AssemblyTests.LoadF…
MaximLipnin Jan 31, 2020
991973d
Remove broken namespace
MaximLipnin Jan 31, 2020
daa2f60
Add an active issue to System.Reflection.Tests.AssemblyTests.LoadFrom…
MaximLipnin Jan 31, 2020
542826b
Add an active issue to several System.Reflection tests
MaximLipnin Feb 3, 2020
0d3519b
Remove skipped System.Tests.ExitCodeTests.SigTermExitCode because it …
MaximLipnin Feb 3, 2020
eb8e367
Remove skipped System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpect…
MaximLipnin Feb 3, 2020
3838bca
Remove skipped System.Tests.GCTests.LatencyRoundtrips from rsp file b…
MaximLipnin Feb 3, 2020
4fd0db2
Remove skipped System.Tests.GCExtendedTests.GetGCMemoryInfo from rsp-…
MaximLipnin Feb 3, 2020
bb40fb8
Remove skipped System.Tests.GetEnvironmentVariable.EnvironmentVariabl…
MaximLipnin Feb 3, 2020
ce32cbc
Turn System.Threading.Tasks.Tests.ExecutionContextFlowTest.TaskComple…
MaximLipnin Feb 3, 2020
f5127c0
Try to re-enable System.Threading.Tasks.Tests.TaskContinueWithTests.L…
MaximLipnin Feb 3, 2020
3a17e8f
Remove skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.Set…
MaximLipnin Feb 3, 2020
380a707
Remove System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxTh…
MaximLipnin Feb 3, 2020
92efedc
Add an active issue to System.Tests.ExitCodeTests.SigTermExitCode and…
MaximLipnin Feb 3, 2020
9edaa39
Remove skipped System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTe…
MaximLipnin Feb 3, 2020
adc7259
Add an active issue to System.Tests.GCExtendedTests.GetGCMemoryInfo b…
MaximLipnin Feb 3, 2020
9919b2a
Add an active issue
MaximLipnin Feb 4, 2020
cc07bdf
Add an active issue
MaximLipnin Feb 4, 2020
938ae1e
Re-add an active issue to System.Tests.ExceptionTests.ThrowStatementD…
MaximLipnin Feb 5, 2020
c58858f
Move skipped System.ComponentModel.Composition.MetadataViewProviderTe…
MaximLipnin Feb 5, 2020
239a4fe
Remove skipped Tests.Integration.ExportFactoryTests.ExportFactoryStan…
MaximLipnin Feb 5, 2020
6dbe861
Remove several skipped System.ComponentModel.Composition.Tests from r…
MaximLipnin Feb 5, 2020
1d3c353
Move skipped System.ComponentModel.Composition.ExportCollectionTests.…
MaximLipnin Feb 5, 2020
5a03664
Move skipped System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_…
MaximLipnin Feb 5, 2020
4e11c67
Move skipped System.Diagnostics.Tests.StackTraceTests.ToString_Invoke…
MaximLipnin Feb 5, 2020
49fa1e9
Remove skipped System.Reflection.Tests.MetadataLoadContextTests.Reloc…
MaximLipnin Feb 5, 2020
b8b2796
Move skipped System.Runtime.Loader.Tests.RefEmitLoadContextTests.Load…
MaximLipnin Feb 5, 2020
50990eb
Moved skipped ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NullA…
MaximLipnin Feb 5, 2020
7e33476
Move skipped System.Runtime.Tests.ProfileOptimizationTest.ProfileOpti…
MaximLipnin Feb 6, 2020
69c299e
Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests with an …
MaximLipnin Feb 6, 2020
23b2e97
Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_Nul…
MaximLipnin Feb 6, 2020
7c50f19
Add an active issue to System.Threading.Tasks.Tests.TaskContinueWithT…
MaximLipnin Feb 7, 2020
1e43fdb
Add an active issue to Tests.Integration.DiscoveryTests.DiscoverAddin…
MaximLipnin Feb 8, 2020
55fb2fe
Add an active issue to System.Threading.ThreadPools.Tests.ThreadPoolT…
MaximLipnin Feb 10, 2020
6d62ffb
Add an active issue to System.ComponentModel.Composition.MetadataAttr…
MaximLipnin Feb 10, 2020
20395ca
Replace TargetFrameworkMonikers.Mono with TestRuntimes.Mono
MaximLipnin Feb 13, 2020
001dbeb
Remove redundant space
MaximLipnin Feb 14, 2020
6a5a07a
Remove all -notrait category
MaximLipnin Feb 14, 2020
b7aa5d3
Add an active issue to System.ComponentModel.Composition.MetadataAttr…
MaximLipnin Feb 14, 2020
3b74374
Add an active issue to System.ComponentModel.Composition.CompositionC…
MaximLipnin Feb 14, 2020
5514c90
Disable the whole System.ComponentModel.Composition.Tests namespace
MaximLipnin Feb 15, 2020
05fe86d
Move some System.Runtime.Loader.Tests, which rely on collectible Asse…
MaximLipnin Feb 17, 2020
07afeb2
Remove three System.Runtime.Loader.Tests.AssemblyLoadContextTest test…
MaximLipnin Feb 17, 2020
6a0d104
Remove System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExi…
MaximLipnin Feb 17, 2020
3ce15ea
Add an active issue to System.Runtime.Loader.Tests.DefaultLoadContext…
MaximLipnin Feb 17, 2020
7779a6b
Move several System.Runtime.Loader.Tests.AssemblyLoadContextTest with…
MaximLipnin Feb 17, 2020
315a4c8
Remove System.Utf8String.Experimental.Tests from rsp file to verify h…
MaximLipnin Feb 18, 2020
16a55ef
Clean up rsp file to check all remaining failures
MaximLipnin Feb 18, 2020
4e28d11
Skip the entire System.ComponentModel.Composition.Registration.Tests …
MaximLipnin Feb 18, 2020
0d3f163
Disable a set of classes in System.Utf8String.Experimental.Tests work…
MaximLipnin Feb 18, 2020
5172b49
Add stubs for Utf8String and Utf8Span.cs classes to fix the test buil…
MaximLipnin Feb 18, 2020
7d0bbc6
Remove nint/nunit aliases unused in PNSE version of Utf8Span
MaximLipnin Feb 18, 2020
19a5e04
Remove CoreFX.issues.rsp file because it has been cleaned up
MaximLipnin Feb 18, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/testing/tests.targets
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
<!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
<ItemGroup>
<_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues.rsp" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_mac.rsp" Condition="'$(TargetOS)' == 'OSX'" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public static partial class PlatformDetection
public static bool IsArgIteratorNotSupported => !IsArgIteratorSupported;
public static bool Is32BitProcess => IntPtr.Size == 4;

// Please make sure that you have the libgdiplus dependency installed.
// For details, see https://docs.microsoft.com/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31#libgdiplus
public static bool IsDrawingSupported
{
get
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Microsoft.VisualBasic.Tests
public class ErrObjectTests
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/14854", TestRuntimes.Mono)]
public void Clear()
{
ProjectData.ClearProjectError();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ public static IEnumerable<object[]> IIf_TestData()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void DeleteSetting()
{
if (!PlatformDetection.IsInAppContainer)
Expand Down Expand Up @@ -207,6 +208,7 @@ private static (string, string)[] GetEnvironmentVariables()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void GetAllSettings()
{
if (!PlatformDetection.IsInAppContainer)
Expand All @@ -221,6 +223,7 @@ public void GetAllSettings()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void GetSetting()
{
if (!PlatformDetection.IsInAppContainer)
Expand Down Expand Up @@ -301,14 +304,14 @@ public void Partition_Overflow(long Number, long Start, long Stop, long Interval
{
Assert.Throws<OverflowException>(() => Interaction.Partition(Number, Start, Stop, Interval));
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void SaveSetting()
{
if (!PlatformDetection.IsInAppContainer)
{
Assert.Throws<ArgumentException>(() => Interaction.SaveSetting(AppName: "", Section: "", Key: "", Setting: ""));

}
else
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ public void IEnumerable_GetAllExpectedItems()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16413", TestRuntimes.Mono)]
public void ReferenceTypes_NulledAfterDequeue()
{
int iterations = 10; // any number <32 will do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public void Ctor_Int(int capacity)
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/14858", TestRuntimes.Mono)]
public void Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException()
{
AssertExtensions.Throws<ArgumentOutOfRangeException>("capacity", () => new NameValueCollection(-1));
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Xunit;

[assembly: SkipOnMono("System.ComponentModel.Composition.Registration APIs are not supported on this platform")]
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="InternalCalls.cs" />
<Compile Include="System\ComponentModel\Composition\Registration\ExportBuilderTests.cs" />
<Compile Include="System\ComponentModel\Composition\Registration\ExportBuilderUnitTests.cs" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Xunit;

[assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

Suggested change
[assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")]
[assembly: ActiveIssue("Flaky tests: https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute 'ActiveIssue' is not valid on this declaration type. It is only valid on 'class, method' declarations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm interesting. I don't see a good reason not to allow ActiveIssue on assembly, will file a PR in dotnet/arcade.

Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<Compile Include="$(CommonTestPath)System\IO\TempFile.cs">
<Link>Common\System\IO\TempFile.cs</Link>
</Compile>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="IMetadataView.cs" />
<Compile Include="MetadataTests_IMetadataView.cs" />
<Compile Include="System\LazyHelper.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public interface ITrans_CollectionOfStrings
public class AdvancedValueComposition
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void RepeatedContainerUse()
{
var container = ContainerFactory.Create();
Expand All @@ -41,6 +42,7 @@ public void RepeatedContainerUse()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void FunctionsFieldsAndProperties()
{
Consumer c;
Expand All @@ -55,6 +57,7 @@ public void FunctionsFieldsAndProperties()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void FunctionsFieldsAndProperties2()
{
Consumer c;
Expand Down Expand Up @@ -252,6 +255,7 @@ public void ImportIntoUntypedExportTest()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportIntoDerivationOfExportException()
{
var container = ContainerFactory.Create();
Expand All @@ -269,6 +273,7 @@ public void ImportIntoDerivationOfExportException()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportIntoDerivationOfExportsException()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@

namespace System.ComponentModel.Composition
{
// [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code, can be removed

Suggested change
// [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]

public class AllowNonPublicCompositionTests
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PublicFromPublic()
{
var container = ContainerFactory.Create();
Expand All @@ -25,6 +27,7 @@ public void PublicFromPublic()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PublicToSelf()
{
var container = ContainerFactory.Create();
Expand All @@ -38,6 +41,7 @@ public void PublicToSelf()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PublicFromPrivate()
{
var container = ContainerFactory.Create();
Expand All @@ -52,6 +56,7 @@ public void PublicFromPrivate()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PrivateFromPublic()
{
var container = ContainerFactory.Create();
Expand All @@ -66,6 +71,7 @@ public void PrivateFromPublic()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PrivateToSelf()
{
var container = ContainerFactory.Create();
Expand All @@ -79,6 +85,7 @@ public void PrivateToSelf()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PrivateData()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

namespace System.ComponentModel.Composition.AttributedModel
{
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class AttributedModelCompositionTests
{
[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace System.ComponentModel.Composition.AttributedModel
public class AttributedModelDiscoveryTests
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_TypeWithExports_ShouldHaveMultipleExports()
{
var definition = CreateDefinition(typeof(PublicComponentWithPublicExports));
Expand All @@ -34,6 +35,7 @@ public class DerivedClassWithInheritedPropertyExports : BaseClassWithPropertyExp
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_TypeWithImports_ShouldHaveMultipleImports()
{
var definition = CreateDefinition(typeof(PublicImportsExpectingPublicExports));
Expand Down Expand Up @@ -156,6 +158,7 @@ public void CreatePartDefinition_MultipleMarkedConstructorsAsPartTypeArgument_Sh
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked()
{
var definition = CreateDefinition(typeof(SimpleConstructorInjectedObject));
Expand All @@ -167,6 +170,7 @@ public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldS
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldSetConstructorToDefault()
{
var definition = CreateDefinition(typeof(PublicComponentWithPublicExports));
Expand All @@ -179,6 +183,7 @@ public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldS
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_OneMarkedAndOneDefaultConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked()
{
var definition = CreateDefinition(typeof(ClassWithOneMarkedAndOneDefaultConstructor));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public void OnImportsSatisfied()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsSatisfiedOnComponentWithoutImports()
{
CompositionContainer container = ContainerFactory.CreateWithAttributedCatalog(typeof(PartWithoutImports));
Expand All @@ -35,6 +36,7 @@ public void ImportsSatisfiedOnComponentWithoutImports()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportCompletedTest()
{
var container = ContainerFactory.Create();
Expand All @@ -56,6 +58,7 @@ public void ImportCompletedTest()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportCompletedWithRecomposing()
{
var container = ContainerFactory.Create();
Expand Down Expand Up @@ -94,6 +97,7 @@ public void ImportCompletedWithRecomposing()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportCompletedAddPartAndBindComponent()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public void Imports_Throws_OnNullContractName()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void Imports()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -158,6 +159,7 @@ public void Imports()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void Imports_CardinalityIgnored_WhenNotSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -170,6 +172,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void Imports_CardinalityNotIgnored_WhenSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand Down Expand Up @@ -200,6 +203,7 @@ public void ImportsGeneric_Throws_OnNullPart()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsGeneric()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -213,6 +217,7 @@ public void ImportsGeneric()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -225,6 +230,7 @@ public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsGeneric_CardinalityNotIgnored_WhenSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public void GetValuesTest()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void NoResolverExceptionTest()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

namespace System.ComponentModel.Composition
{
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class CompositionContainerCollectionTests
{
public class SupportedImportCollectionAssignments<T>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

namespace System.ComponentModel.Composition
{
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class CompositionContainerImportTests
{
// Exporting collectin values is not supported
Expand Down
Loading