-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][xunit tests] Move skipped tests out of rsp file #2087
Merged
akoeplinger
merged 96 commits into
dotnet:master
from
MaximLipnin:move_skipped_tests_out_of_rsp_file
Feb 18, 2020
Merged
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
d464af7
[xunit tests][mono] Remove disabled Microsoft.VisualBasic.Core.Tests …
MaximLipnin de634c5
[xunit tests][mono] Remove System.Collections.Specialized.Tests.Ctor_…
MaximLipnin d1d6386
Remove System.Collections.Concurrent.Tests.ConcurrentQueueTests.Refer…
MaximLipnin 62a31f4
Remove BasicEventSourceTests.TestsManifestNegative.Test_GenerateManif…
MaximLipnin 1b21ae4
Remove ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolut…
MaximLipnin f63488b
Remove System.IO.Tests.*.CopyFileWithData_MemberData from rsp file
MaximLipnin 5c9e2c2
Move a set of skipped System.Linq.Expressions.Tests out of rsp file.
MaximLipnin 8b7f4a7
Annotate System.Collections.Concurrent.Tests.ConcurrentQueueTests.Ref…
MaximLipnin 870a16a
Move another set of skipped System.Linq.Expressions.Tests out of rsp …
MaximLipnin fa9dfb5
Move skipped System.Linq.Parallel.Tests.PlinqModesTests.WithExecution…
MaximLipnin 9c6144d
Move skipped System.Memory.Tests out of rsp file
MaximLipnin 43f57d8
Move skipped System.Net.Http.Functional.Tests.PlatformHandler_HttpCli…
MaximLipnin 46cc919
Remove System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterfa…
MaximLipnin 310b879
Move System.Reflection tests with an active issue out of rsp file
MaximLipnin 81f97fc
Move skipped System.Runtime.InteropServices.Tests out of rsp file
MaximLipnin b705010
Replace closed CoreFX GH issue with the active Runtime one
MaximLipnin f444ffb
Move skipped System.Runtime.Serialization.Formatters.Tests out of rsp…
MaximLipnin 3311ccc
Move skipped System.Runtime.Tests with an active issue out of rsp file
MaximLipnin d911dad
Move skipped System.Threading.Tests with an active issue out of rsp file
MaximLipnin b278278
Remove skipped System.Data.Common.Tests because the related issue was…
MaximLipnin 3aa460e
Move skipped System.Data.Common.Tests.DbConnectionTests.ProviderFacto…
MaximLipnin e1a4e85
Move skipped System.Diagnostics.StackTrace.Tests with an active issue…
MaximLipnin 920d42d
Move skipped System.Numerics.Vectors.Tests with an active issue out o…
MaximLipnin 07722f1
Move skipped System.Reflection.Context.Tests with an active issue out…
MaximLipnin 5d3788e
Move skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMi…
MaximLipnin 288b12d
Move skipped System.ComponentModel.Composition and Tests.Integration …
MaximLipnin e146c57
Update a message in skipped System.Runtime.InteropServices.Tests
MaximLipnin d9cd430
Move skipped System.Reflection.Tests.MetadataTokenTests.SuccessImplie…
MaximLipnin fd2b05f
Move skipped/no repro System.Threading.Overlapped.Tests with an activ…
MaximLipnin d0c9bd7
Move skipped System.Runtime.Extensions with an active issue out of rs…
MaximLipnin a0c84bf
Re-enable skipped System.Runtime.Handles.Tests because the related is…
MaximLipnin 8612c52
Move skipped System.Reflection.TypeExtensions.Tests with an active is…
MaximLipnin bab4de6
Move skipped System.Reflection.Emit.Lightweight.Tests with an active …
MaximLipnin 90e0f05
Move skipped System.Reflection.MetadataLoadContext.Tests with an acti…
MaximLipnin 8fc9fc8
Move skipped System.Xml.Xsl.XslTransformApi.Tests with an active issu…
MaximLipnin fc5784f
Move skipped System.Security.Cryptography.Encoding.Tests with an acti…
MaximLipnin 3d0e18f
Move System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix…
MaximLipnin 110dd50
Add an active issue attribute to System.Drawing.Imaging.Tests.ImageAt…
MaximLipnin 9c845ef
Move System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHa…
MaximLipnin 5b9f525
Remove System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClient…
MaximLipnin 798166e
Move skipped System.Reflection.Emit.ILGeneration.Tests with an active…
MaximLipnin 5bb95df
Move skipped System.Reflection.Emit.Tests with an active issue out of…
MaximLipnin fd36223
Remove skipped System.Reflection.Tests from rsp file because they pas…
MaximLipnin 30b1399
Try to re-enabled skipped System.Reflection.Tests.AssemblyTests.LoadF…
MaximLipnin 991973d
Remove broken namespace
MaximLipnin daa2f60
Add an active issue to System.Reflection.Tests.AssemblyTests.LoadFrom…
MaximLipnin 542826b
Add an active issue to several System.Reflection tests
MaximLipnin 0d3519b
Remove skipped System.Tests.ExitCodeTests.SigTermExitCode because it …
MaximLipnin eb8e367
Remove skipped System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpect…
MaximLipnin 3838bca
Remove skipped System.Tests.GCTests.LatencyRoundtrips from rsp file b…
MaximLipnin 4fd0db2
Remove skipped System.Tests.GCExtendedTests.GetGCMemoryInfo from rsp-…
MaximLipnin bb40fb8
Remove skipped System.Tests.GetEnvironmentVariable.EnvironmentVariabl…
MaximLipnin ce32cbc
Turn System.Threading.Tasks.Tests.ExecutionContextFlowTest.TaskComple…
MaximLipnin f5127c0
Try to re-enable System.Threading.Tasks.Tests.TaskContinueWithTests.L…
MaximLipnin 3a17e8f
Remove skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.Set…
MaximLipnin 380a707
Remove System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxTh…
MaximLipnin 92efedc
Add an active issue to System.Tests.ExitCodeTests.SigTermExitCode and…
MaximLipnin 9edaa39
Remove skipped System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTe…
MaximLipnin adc7259
Add an active issue to System.Tests.GCExtendedTests.GetGCMemoryInfo b…
MaximLipnin 9919b2a
Add an active issue
MaximLipnin cc07bdf
Add an active issue
MaximLipnin 938ae1e
Re-add an active issue to System.Tests.ExceptionTests.ThrowStatementD…
MaximLipnin c58858f
Move skipped System.ComponentModel.Composition.MetadataViewProviderTe…
MaximLipnin 239a4fe
Remove skipped Tests.Integration.ExportFactoryTests.ExportFactoryStan…
MaximLipnin 6dbe861
Remove several skipped System.ComponentModel.Composition.Tests from r…
MaximLipnin 1d3c353
Move skipped System.ComponentModel.Composition.ExportCollectionTests.…
MaximLipnin 5a03664
Move skipped System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_…
MaximLipnin 4e11c67
Move skipped System.Diagnostics.Tests.StackTraceTests.ToString_Invoke…
MaximLipnin 49fa1e9
Remove skipped System.Reflection.Tests.MetadataLoadContextTests.Reloc…
MaximLipnin b8b2796
Move skipped System.Runtime.Loader.Tests.RefEmitLoadContextTests.Load…
MaximLipnin 50990eb
Moved skipped ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NullA…
MaximLipnin 7e33476
Move skipped System.Runtime.Tests.ProfileOptimizationTest.ProfileOpti…
MaximLipnin 69c299e
Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests with an …
MaximLipnin 23b2e97
Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_Nul…
MaximLipnin 7c50f19
Add an active issue to System.Threading.Tasks.Tests.TaskContinueWithT…
MaximLipnin 1e43fdb
Add an active issue to Tests.Integration.DiscoveryTests.DiscoverAddin…
MaximLipnin 55fb2fe
Add an active issue to System.Threading.ThreadPools.Tests.ThreadPoolT…
MaximLipnin 6d62ffb
Add an active issue to System.ComponentModel.Composition.MetadataAttr…
MaximLipnin 20395ca
Replace TargetFrameworkMonikers.Mono with TestRuntimes.Mono
MaximLipnin 001dbeb
Remove redundant space
MaximLipnin 6a5a07a
Remove all -notrait category
MaximLipnin b7aa5d3
Add an active issue to System.ComponentModel.Composition.MetadataAttr…
MaximLipnin 3b74374
Add an active issue to System.ComponentModel.Composition.CompositionC…
MaximLipnin 5514c90
Disable the whole System.ComponentModel.Composition.Tests namespace
MaximLipnin 05fe86d
Move some System.Runtime.Loader.Tests, which rely on collectible Asse…
MaximLipnin 07afeb2
Remove three System.Runtime.Loader.Tests.AssemblyLoadContextTest test…
MaximLipnin 6a0d104
Remove System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExi…
MaximLipnin 3ce15ea
Add an active issue to System.Runtime.Loader.Tests.DefaultLoadContext…
MaximLipnin 7779a6b
Move several System.Runtime.Loader.Tests.AssemblyLoadContextTest with…
MaximLipnin 315a4c8
Remove System.Utf8String.Experimental.Tests from rsp file to verify h…
MaximLipnin 16a55ef
Clean up rsp file to check all remaining failures
MaximLipnin 4e28d11
Skip the entire System.ComponentModel.Composition.Registration.Tests …
MaximLipnin 0d3f163
Disable a set of classes in System.Utf8String.Experimental.Tests work…
MaximLipnin 5172b49
Add stubs for Utf8String and Utf8Span.cs classes to fix the test buil…
MaximLipnin 7d0bbc6
Remove nint/nunit aliases unused in PNSE version of Utf8Span
MaximLipnin 19a5e04
Remove CoreFX.issues.rsp file because it has been cleaned up
MaximLipnin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/libraries/System.ComponentModel.Composition.Registration/tests/AssemblyInfo.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using Xunit; | ||
|
||
[assembly: SkipOnMono("System.ComponentModel.Composition.Registration APIs are not supported on this platform")] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using Xunit; | ||
|
||
[assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -8,9 +8,11 @@ | |||
|
||||
namespace System.ComponentModel.Composition | ||||
{ | ||||
// [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. commented code, can be removed
Suggested change
|
||||
public class AllowNonPublicCompositionTests | ||||
{ | ||||
[Fact] | ||||
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
public void PublicFromPublic() | ||||
{ | ||||
var container = ContainerFactory.Create(); | ||||
|
@@ -25,6 +27,7 @@ public void PublicFromPublic() | |||
} | ||||
|
||||
[Fact] | ||||
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
public void PublicToSelf() | ||||
{ | ||||
var container = ContainerFactory.Create(); | ||||
|
@@ -38,6 +41,7 @@ public void PublicToSelf() | |||
} | ||||
|
||||
[Fact] | ||||
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
public void PublicFromPrivate() | ||||
{ | ||||
var container = ContainerFactory.Create(); | ||||
|
@@ -52,6 +56,7 @@ public void PublicFromPrivate() | |||
} | ||||
|
||||
[Fact] | ||||
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
public void PrivateFromPublic() | ||||
{ | ||||
var container = ContainerFactory.Create(); | ||||
|
@@ -66,6 +71,7 @@ public void PrivateFromPublic() | |||
} | ||||
|
||||
[Fact] | ||||
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
public void PrivateToSelf() | ||||
{ | ||||
var container = ContainerFactory.Create(); | ||||
|
@@ -79,6 +85,7 @@ public void PrivateToSelf() | |||
} | ||||
|
||||
[Fact] | ||||
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||||
public void PrivateData() | ||||
{ | ||||
var container = ContainerFactory.Create(); | ||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribute 'ActiveIssue' is not valid on this declaration type. It is only valid on 'class, method' declarations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm interesting. I don't see a good reason not to allow
ActiveIssue
on assembly, will file a PR in dotnet/arcade.