WinHttpHandler tests are back #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/System.Net.Http.WinHttpHandler.Functional.Tests.csproj
|
/azp list |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No failed tests, cancelled due to timeouts. |
# Conflicts: # src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.DefaultProxyCredentials.cs # src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs # src/libraries/Common/tests/System/Net/Http/SchSendAuxRecordHttpTest.cs # src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs
scalablecory
approved these changes
Jan 17, 2020
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Authentication.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AutoRedirect.cs
Outdated
Show resolved
Hide resolved
| // Propagate exception for debugging | ||
| task.GetAwaiter().GetResult(); | ||
| // With WinHttpHandler, we may fault because canceling the task destroys the request handle | ||
| // which may randomly cause an ObjectDisposedException (or other exception). |
There was a problem hiding this comment.
Seeing an ObjectDisposedException upon cancellation seems like a bug. @davidsh do you know anything about this behavior?
There was a problem hiding this comment.
Note that this is just taken from before WinHttpHandler removal in this commit. As is every other condition returned to the tests.
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AutoRedirect.cs
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AutoRedirect.cs
Show resolved
Hide resolved
Yep, the lesser evil 😄 |
scalablecory
approved these changes
Jan 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests used by
PlatformHandlerTestmoved to Common/tests in order to share them between System.Net.Http and System.Net.Http.WinHttpHandler.The added conditions correspond to the state before WinHttpHandler removal. They're just based on
IsWinHttpHandlerinstead ofUseSocketHandler.Some of the code must be conditionally compiled since there is no usable common base class for
HttpClientHandlerandWinHttpHandler. Other issues solved by introducingWinHttpClientHandlerfor testing purposes. It corresponds to HttpClientHandler.Windows.cs code from before its removal.Resolves #339