Skip to content

Don't pass empty string as SNI to QUIC - #133097

Merged
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:quic-sni-null
Sep 3, 2026
Merged

rzikm merged 2 commits into
dotnet:mainfrom
rzikm:quic-sni-null

Apply suggestion from @rzikm

8a87307
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Sep 2, 2026 in 0s

.NET Result Analysis

Details

‼️ Build Analysis Check Result has been manually overridden

  • The build analysis check result has been updated by the user for the following reason: test failures are unrelated
  • The check result has changed from Failure to Success

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Known test errors

Test Failures (2 tests failed)

🔹 [All failing tests from runtime]

    ❌ System.Net.Security.Tests.SslStreamTlsResumeTests.ClientCert_DefaultValue_ResumeSucceeds [Console] [Details] [Artifacts] [0.07% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]

    Failing Configuration

    Data Driven SubResults
      ❌ System.Net.Security.Tests.SslStreamTlsResumeTests.ClientCert_DefaultValue_ResumeSucceeds(sslProtocol: Tls12, certificateRequired: True, certSource: ClientCertificate)
      Exception Message
      Assert.Equal() Failure: Values differ\r\nExpected: True\r\nActual:   False
      Stack Trace
      at System.Net.Security.Tests.SslStreamTlsResumeTests.RunConnectionAsync(SslServerAuthenticationOptions serverOptions, SslClientAuthenticationOptions clientOptions, Nullable`1 expectResume) in /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs:line 256
         at System.Net.Security.Tests.SslStreamTlsResumeTests.ResumeSucceedsInternal(SslServerAuthenticationOptions serverOptions, SslClientAuthenticationOptions clientOptions) in /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs:line 240
      --- End of stack trace from previous location ---
    ❌ System.Net.Sockets.Tests.SendReceive_MemoryNativeTask.TcpReceiveSendGetsCanceledByDispose [Console] [Details] [Artifacts] [0.57% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]

    Failing Configuration

    Data Driven SubResults
      ❌ System.Net.Sockets.Tests.SendReceive_MemoryNativeTask.TcpReceiveSendGetsCanceledByDispose(receiveOrSend: False, ipv6Server: False, dualModeClient: True, owning: True)
      Exception Message
      System.TimeoutException : The operation has timed out.
      Stack Trace
      at System.Runtime.CompilerServices.RuntimeAsyncTaskContinuation.GetResult[T](Task task, Byte& result) in /_/src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeAsyncTaskContinuation.cs:line 139
         at System.Net.Sockets.Tests.SendReceive`1.<>c__DisplayClass21_0.<TcpReceiveSendGetsCanceledByDispose>b__0() in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs:line 1129
         at System.RetryHelper.ExecuteAsync(Func`1 test, Int32 maxAttempts, Func`2 backoffFunc, Predicate`1 retryWhen, String testName) in /_/src/libraries/Common/tests/TestUtilities/System/RetryHelper.cs:line 94
         at System.RetryHelper.ExecuteAsync(Func`1 test, Int32 maxAttempts, Func`2 backoffFunc, Predicate`1 retryWhen, String testName)
         at System.Net.Sockets.Tests.SendReceive`1.TcpReceiveSendGetsCanceledByDispose(Boolean receiveOrSend, Boolean ipv6Server, Boolean dualModeClient, Boolean owning) in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs:line 1057
      --- End of stack trace from previous location ---

Was this helpful? Yes No