Open
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failure for GetAsync_Chunked_VaryingSizeChunks_ReceivedCorrectly
Use CRLF for chunked response framing test
Aug 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/libraries/Common/tests/System/Net/Http/HttpProtocolTests.cs:389
- GetAsync_Chunked_VaryingSizeChunks_ReceivedCorrectly_MemberData still loops over a single-value lineEnding array. Now that only CRLF is valid, consider simplifying the MemberData generation to remove the redundant loop and avoid implying multiple line endings are being exercised.
foreach (int maxChunkSize in new[] { 1, 10_000 })
foreach (string lineEnding in new[] { "\r\n" })
foreach (bool useCopyToAsync in new[] { false, true })
yield return new object[] { maxChunkSize, lineEnding, useCopyToAsync };
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
MihaZupan
approved these changes
Aug 11, 2026
This was referenced Aug 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main PR N/A
Description
The chunked-response test generated bare-LF chunk delimiters, which the HTTP/1.1 parser now correctly rejects. Limit its framing data to CRLF while retaining chunk-size and read-path coverage.
Removes only invalid chunked framing; unrelated status-line and header LF coverage remains unchanged.
Customer Impact
Eliminates persistent outerloop failures across HTTP handler variants.
Regression
Test regression following strict CRLF enforcement for HTTP/1.1 chunked encoding.
Testing
The existing theory continues to cover both chunk-size ranges and synchronous/asynchronous stream consumption.
Risk
Low: test-data-only change aligned with RFC-compliant parser behavior.
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Note
This PR description was generated by GitHub Copilot.