Skip to content

[release/9.0-staging] [TestOnly] Fix NumberFormatInfoGroupSize test #128578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 2 commits into from
Jun 4, 2026
+8 −5
Merged

[release/9.0-staging] [TestOnly] Fix NumberFormatInfoGroupSize test #128578

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
572b4ea
Fix NumberFormatInfoGroupSize test (#120546)
tarekgh Oct 8, 2025
b666875
Use Span to avoid requiring System.Linq
svick May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...ime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,24 @@
{
public static IEnumerable<object[]> NumberGroupSizes_TestData()
{
yield return new object[] { NumberFormatInfo.InvariantInfo, new int[] { 3 } };
yield return new object[] { CultureInfo.GetCultureInfo("en-US").NumberFormat, new int[] { 3 } };
yield return new object[] { "Invariant", NumberFormatInfo.InvariantInfo, new int[] { 3 }, null };
yield return new object[] { "en-US", CultureInfo.GetCultureInfo("en-US").NumberFormat, new int[] { 3 }, null };

// Culture does not exist on Windows 7 and in Browser's ICU
if (!PlatformDetection.IsWindows7 && PlatformDetection.IsNotBrowser)
{
yield return new object[] { CultureInfo.GetCultureInfo("ur-IN").NumberFormat, NumberFormatInfoData.UrINNumberGroupSizes() };
yield return new object[] { "ur-IN", CultureInfo.GetCultureInfo("ur-IN").NumberFormat, NumberFormatInfoData.UrINNumberGroupSizes(), new int[] { 3, 2 } };
}
}

[Theory]
[MemberData(nameof(NumberGroupSizes_TestData))]
public void NumberGroupSizes_Get_ReturnsExpected(NumberFormatInfo format, int[] expected)
public void NumberGroupSizes_Get_ReturnsExpected(string cultureName, NumberFormatInfo format, int[] expected1, int[] expected2)
{
Assert.Equal(expected, format.NumberGroupSizes);
int[] actual = format.NumberGroupSizes;
Assert.True(expected1.SequenceEqual(actual) || (expected2 is not null && expected2.SequenceEqual(actual)),

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,96): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 28 in src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs#L28 

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs(28,35): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'int[]' does not contain a definition for 'SequenceEqual' and no accessible extension method 'SequenceEqual' accepting a first argument of type 'int[]' could be found (are you missing a using directive or an assembly reference?)
$"Expected: [{string.Join(", ", expected1)}] or [{(expected2 is null ? "<null>" : string.Join(", ", expected2))}], Actual: [{string.Join(", ", actual)}]"
+ $"{Environment.NewLine}Culture: {cultureName}");
}

[Theory]
Expand Down
Loading