Skip to content

Ensure gtInitializeStoreNode consistently handles SIMD/Mask stores for all platforms - #128013

Merged
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:set-simd-related
May 12, 2026
Merged

Ensure gtInitializeStoreNode consistently handles SIMD/Mask stores for all platforms#128013
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:set-simd-related

Conversation

@tannergooding

Copy link
Copy Markdown
Member

This was consistent for everything except x86 and we weren't handling masks as intended for x64.

Copilot AI review requested due to automatic review settings May 10, 2026 23:52
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 10, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Compiler::gtInitializeStoreNode so that SIMD and mask local stores are consistently marked as “related to SIMD intrinsics” across all target platforms, eliminating the prior x86-only special-case and extending the behavior to mask stores (when enabled).

Changes:

  • Replace the x86-only heuristic with a single all-arch path.
  • Detect SIMD/mask stores via varTypeIsSIMDOrMask(store) and apply SetOpLclRelatedToSIMDIntrinsic consistently to both the store node and the stored value (preserving the existing retbuf-call exclusion).

@tannergooding
tannergooding marked this pull request as ready for review May 12, 2026 12:35
Copilot AI review requested due to automatic review settings May 12, 2026 12:35
@tannergooding

Copy link
Copy Markdown
Member Author

CC. @jakobbotsch, @EgorBo. Minor code cleanup to ensure x86 (32-bit) is consistent with other SIMD platforms, removes an ifdef.

Provides minor improvements to x86 fullopts:

Overall (-3,868 bytes)
FullOpts (-3,868 bytes)
Example diffs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@tannergooding
tannergooding enabled auto-merge (squash) May 12, 2026 13:06
@tannergooding

Copy link
Copy Markdown
Member Author

/ba-g unrelated timeouts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants