Ensure gtInitializeStoreNode consistently handles SIMD/Mask stores for all platforms - #128013
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Compiler::gtInitializeStoreNode so that SIMD and mask local stores are consistently marked as “related to SIMD intrinsics” across all target platforms, eliminating the prior x86-only special-case and extending the behavior to mask stores (when enabled).
Changes:
- Replace the x86-only heuristic with a single all-arch path.
- Detect SIMD/mask stores via
varTypeIsSIMDOrMask(store)and applySetOpLclRelatedToSIMDIntrinsicconsistently to both the store node and the stored value (preserving the existing retbuf-call exclusion).
Open
3 tasks
Member
Author
|
CC. @jakobbotsch, @EgorBo. Minor code cleanup to ensure x86 (32-bit) is consistent with other SIMD platforms, removes an ifdef. Provides minor improvements to x86 fullopts: |
EgorBo
approved these changes
May 12, 2026
tannergooding
enabled auto-merge (squash)
May 12, 2026 13:06
Member
Author
|
/ba-g unrelated timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was consistent for everything except x86 and we weren't handling masks as intended for x64.