Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tests/JIT/HardwareIntrinsics/Arm/Sve2/Sve2_r.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<!-- https://github.com/dotnet/runtime/issues/127955 -->
<JitOptimizationSensitive>true</JitOptimizationSensitive>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this failing test be disable using ActiveIssue instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is quite unusual. I think it is coming from

Muting PR — small, clean, mergeable PR that just adds [ActiveIssue(...)] / referencing the KBE. No diagnosis logic, no product code. Designed to be merge-without-thinking by any maintainer who agrees the failure should be silenced. Always produced when (1) is produced.

I will iterate on this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 9b5d923: switched from JitOptimizationSensitive to ActiveIssue-based muting (conditioned on CoreClrConfigurationDetection.IsAnyJitStress) for these failing tests.

</PropertyGroup>
<PropertyGroup>
<DebugType>Embedded</DebugType>
Expand Down
4 changes: 4 additions & 0 deletions src/tests/JIT/HardwareIntrinsics/Arm/Sve2/Sve2_ro.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- https://github.com/dotnet/runtime/issues/127955 -->
<JitOptimizationSensitive>true</JitOptimizationSensitive>
</PropertyGroup>
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Optimize>True</Optimize>
<!-- https://github.com/dotnet/runtime/issues/127955 -->
<JitOptimizationSensitive>true</JitOptimizationSensitive>
<NoWarn>$(NoWarn);SYSLIB5003</NoWarn>
</PropertyGroup>
<ItemGroup>
Expand Down
Loading