-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[browser] More Wasm.Build.Tests on CoreCLR #127281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maraf
wants to merge
22
commits into
dotnet:main
Choose a base branch
from
maraf:maraf/wbt-coreclr-enable-non-aot-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8debc4a
Enable non-AOT WBT tests on CoreCLR in 4 native test classes
maraf 65e6237
Enable ICU, InvariantGlobalization, and Memory tests on CoreCLR
Copilot 1fa4950
Add newly enabled WBT classes to CoreCLR Helix jobs list
maraf 123b863
Fix WBT template install on read-only Helix correlation
maraf 5250927
Fix WBT template install DOTNET_CLI_HOME mismatch on Helix
maraf 14cace4
Fix WBT CoreCLR native relink, ICU pack lookup, variadic test scope
maraf e17204d
Ship coreclr_compat.h as a static file next to BrowserWasmApp.CoreCLR…
maraf 1eb48af
Use ICU-specific main.js for Wasm.Build.Tests IcuTests
maraf 418cd2b
Split emcc compile pass for user vs generated sources in CoreCLR-Wasm
maraf 827800e
Merge remote-tracking branch 'origin/main' into maraf/wbt-coreclr-ena…
maraf 532e645
Ship minipal/utils.h to WBT Helix payload for CoreCLR re-link
7509361
Resolve ICU asset src path from build-resolved runtime pack
a7b3362
Ship libSystem.Native.Browser.extpost.js in browser-wasm runtime pack
905c755
Install libSystem.Native.Browser.extpost.js into sharedFramework
maraf 9d4e5ce
Include static libs in browser-wasm CoreCLR runtime pack
maraf 34f2aa2
Auto-enable WasmBuildNative for CoreCLR when NativeFileReference/Nati…
maraf c0b0e63
Exclude duplicate libs from browser-wasm CoreCLR runtime pack
maraf 51b99d0
Treat CoreCLR as always workload
maraf 0388696
Use icu_main.js for Wasm.Build.Tests DllImport variadic-function tests
maraf 45afe55
Use minimal main.js for more Wasm.Build.Tests CoreCLR scenarios
maraf bef4e8b
Mark IcallWithOverloadedParametersAndEnum as mono-only
maraf 37cdc06
Revert "Treat CoreCLR as always workload"
maraf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says additional
TestCategory("native")classes likeIcuTestsare "not in scope" and left for follow-up, but this change addsIcu*,InvariantGlobalizationTests, andMemoryTeststo the CoreCLR job list. Either update the PR description to reflect the expanded scope or remove these additions to match the stated intent.