Skip to content

arm64: Clean up SVE embedded masked codegen #127164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhartglassMSFT merged 12 commits into from
Jun 30, 2026
Merged

arm64: Clean up SVE embedded masked codegen #127164

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
73b0128
Clean up SVE embedded masked codegen
ylpoonlg Jan 22, 2026
4cddda0
Fix optional embedded masked with true mask
ylpoonlg Apr 23, 2026
42b67e6
Refactor RMW register check function
ylpoonlg May 5, 2026
cf72018
Fix SVE opt tests
ylpoonlg May 5, 2026
d144b80
extra checks for unary embedded masked ops in lsra
a74nh Jun 24, 2026
c11e121
Add special cases for ConvertToSingleOddRoundToOdd
a74nh Jun 24, 2026
9dda2b4
Merge remote-tracking branch 'origin/main' into github-movprfx_refact…
ylpoon-arm Jun 24, 2026
235dd4c
Fix formatting
ylpoonlg Jun 24, 2026
3b0e5a9
Merge branch 'main' into github-movprfx_refactor_3
dhartglassMSFT Jun 24, 2026
f4f9c8f
reserve register for MultiplyAddRotateComplex
a74nh Jun 29, 2026
cd44faf
Fix format
ylpoonlg Jun 29, 2026
c981363
fix checkRMWRegisters for FMA embedded ops
a74nh Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/jit/codegen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,8 @@ class CodeGen final : public CodeGenInterface
#endif // defined(TARGET_XARCH)

#ifdef TARGET_ARM64
void genEmbeddedMaskedHWIntrinsic(const HWIntrinsic intrinCndSel, regNumber targetReg);

class HWIntrinsicImmOpHelper final
{
public:
Expand Down
5 changes: 4 additions & 1 deletion src/coreclr/jit/emitarm64sve.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19339,7 +19339,10 @@ void emitter::emitInsPairSanityCheck(instrDesc* firstId, instrDesc* secondId)
assert(firstId->idReg2() == secondId->idReg2());

// "predicated using the same governing predicate register and source element size as this instruction."
assert(firstId->idInsOpt() == secondId->idInsOpt());
emitAttr dstSize1 = optGetSveElemsize(firstId->idInsOpt());
emitAttr dstSize2 = insOptsScalableStandard(secondId->idInsOpt()) ? optGetSveElemsize(secondId->idInsOpt())
: optGetDstsize(secondId->idInsOpt());
assert(dstSize1 == dstSize2);
}

// The following instructions cannot use predicated movprfx, else the behaviour will be unpredictable.
Expand Down
1,110 changes: 476 additions & 634 deletions src/coreclr/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 12 additions & 9 deletions src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4074,23 +4074,26 @@ void Lowering::ContainCheckHWIntrinsic(GenTreeHWIntrinsic* node)
}

// Handle op3
if (op3->IsVectorZero() && op1->IsTrueMask(node->GetSimdBaseType()) && op2->IsEmbMaskOp())
if (op3->IsVectorZero() && op2->IsEmbMaskOp())
{
// When we are merging with zero, we can specialize
// and avoid instantiating the vector constant.
// Do this only if op1 was AllTrueMask
// When we are merging with zero, we can specialize and avoid instantiating the vector constant.
switch (op2->AsHWIntrinsic()->GetHWIntrinsicId())
{
case NI_Sve2_AddPairwise:
case NI_Sve2_MaxNumberPairwise:
case NI_Sve2_MaxPairwise:
case NI_Sve2_MinNumberPairwise:
case NI_Sve2_MinPairwise:
// This is an edge case where these instructions have unpredictable behaviour when
// using predicated movprfx, so the unpredicated variant must be used here. This
// prevents us from performing this optimization as we will need the constant vector
// for masking the result.
break;
case NI_Sve2_ConvertToDoubleOdd:
case NI_Sve2_ConvertToSingleOdd:
case NI_Sve2_ConvertToSingleOddRoundToOdd:
// This is an edge case where these instructions do not support predicated or any movprfx.
if (!op1->IsTrueMask(node->GetSimdBaseType()))
{
// When op1 is not all-true, we will need the constant vector for masking the result.
break;
}
FALLTHROUGH;

default:
MakeSrcContained(node, op3);
Expand Down
8 changes: 7 additions & 1 deletion src/coreclr/jit/lsraarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,6 @@ int LinearScan::BuildHWIntrinsic(GenTreeHWIntrinsic* intrinsicTree, int* pDstCou
{
assert(addrOp != operand);
assert(consecutiveOp != operand);
assert(delayFreeOp != operand);
Comment thread
ylpoonlg marked this conversation as resolved.

srcCount += BuildEmbeddedOperandUses(embeddedOp, delayFreeOp);
}
Expand Down Expand Up @@ -2356,6 +2355,13 @@ GenTree* LinearScan::getDelayFreeOperand(GenTreeHWIntrinsic* intrinsicTree, bool
assert(delayFreeOp != nullptr);
}
}
else if (intrinsicTree->GetOperandCount() == 1 && embedded)
{
// 1-operand embedded masked operations are non-RMW, but they could also use movprfx.
// Set delayFreeOp to the embedded node itself so that op1 can be delay-freed.
delayFreeOp = intrinsicTree;
assert(delayFreeOp != nullptr);
Comment thread
ylpoonlg marked this conversation as resolved.
}
break;
}

Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVector.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2BaseType}* op2, {Op3VectorType}<{Op3BaseType}> op3, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVectorByteOffsetFirstFaulting.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2BaseType}* op2, {Op3VectorType}<{Op3BaseType}> op3, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVectorByteOffsets.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2BaseType}* op2, {Op3VectorType}<{Op3BaseType}> op3, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVectorFirstFaultingVectorBases.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVectorVectorBases.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryMaskOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op1VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Comment thread
dhartglassMSFT marked this conversation as resolved.
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion ...tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryOpDifferentRetTypeTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {RetVectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == {RetVectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), {RetVectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryOpDifferentTypesTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue(Vector<{RetBaseType}> mask, Vector<{Op1BaseType}> op1, Vector<{Op2BaseType}> op2, Vector<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == Vector<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), Vector<{RetBaseType}>.Zero) :
Comment thread
dhartglassMSFT marked this conversation as resolved.
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
ValidateConditionalSelectResult(mask, op1, op2, falseOp, result);
}

Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryRetMaskOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op1VectorType}<{Op1BaseType}> op2, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveImm2TernOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {Op3VectorType}<{Op3BaseType}> op3, {RetVectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, {Imm1}, {Imm2}), falseOp);
var result = (falseOp == {RetVectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, {Imm1}, {Imm2}), {RetVectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, {Imm1}, {Imm2}), falseOp);
Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
}
Expand Down
4 changes: 3 additions & 1 deletion ...ts/JIT/HardwareIntrinsics/Arm/Shared/_SveImmBinaryOpDifferentRetTypeTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {RetVectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, Imm), falseOp);
var result = (falseOp == {RetVectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, Imm), {RetVectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, Imm), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveImmBinaryOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op2VectorType}<{Op2BaseType}> op2, {RetVectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, {Imm}), falseOp);
var result = (falseOp == {RetVectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, {Imm}), {RetVectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, {Imm}), falseOp);
Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, falseOp, _dataTable.outArrayPtr);
}
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveImmTernOpFirstArgTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op1VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op3BaseType}> op3, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, Imm), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, Imm), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, Imm), falseOp);
Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
}
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveImmTernOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({Op1VectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op1VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op3BaseType}> op3, {Op1VectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, Imm), falseOp);
var result = (falseOp == {Op1VectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, Imm), {Op1VectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3, Imm), falseOp);
Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
}
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveImmUnaryOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op, {RetVectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op, {Imm}), falseOp);
var result = (falseOp == {RetVectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op, {Imm}), {RetVectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op, {Imm}), falseOp);
Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op, falseOp, Imm, _dataTable.outArrayPtr);
}
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveMinimalUnaryOpTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {RetVectorType}<{RetBaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1), falseOp);
var result = (falseOp == {RetVectorType}<{RetBaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1), {RetVectorType}<{RetBaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, falseOp, _dataTable.outArrayPtr);
Expand Down
4 changes: 3 additions & 1 deletion src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveTernOpFirstArgTestTemplate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,9 @@ namespace {Namespace}
[method: MethodImpl(MethodImplOptions.AggressiveInlining)]
private void ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}> mask, {Op1VectorType}<{Op1BaseType}> op1, {Op1VectorType}<{Op2BaseType}> op2, {Op1VectorType}<{Op3BaseType}> op3, {Op1VectorType}<{Op1BaseType}> falseOp)
{
var result = Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);
var result = (falseOp == {Op1VectorType}<{Op1BaseType}>.Zero) ?
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), {Op1VectorType}<{Op1BaseType}>.Zero) :
Sve.ConditionalSelect(mask, {Isa}.{Method}(op1, op2, op3), falseOp);

Unsafe.Write(_dataTable.outArrayPtr, result);
ValidateConditionalSelectResult_TrueValue(mask, op1, op2, op3, falseOp, _dataTable.outArrayPtr);
Expand Down
Loading
Loading