Implement SafeProcessHandle.WaitForExit* methods#127022
Merged
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the approved
SafeProcessHandle.WaitForExit*API surface from #123380.Description
Adds 5 new public methods to
SafeProcessHandle:WaitForExit,TryWaitForExit,WaitForExitOrKillOnTimeout,WaitForExitAsync, andWaitForExitOrKillOnCancellationAsync.Key changes
SafeProcessHandle.csusingRegisterWaitForSingleObject+TaskCompletionSourceProcessWaitHandle+GetExitCodeProcessfor synchronous wait and exit code retrievalProcessWaitStatefor reaping coordination;ProcessIdproperty moved to platform-specific file and reads from_waitStateHolder._state._processIdWaitPidExitedNoHangnow returns terminating signal info viaTryConvertSignalCodeToPosixSignalProcessExitStatus?instead of separate_exitCode/_terminatingSignalfields; addedHolder.IncrementRefCount()for ref-counted ownership sharing betweenProcessandSafeProcessHandleGetProcessHandle()andStartCoreuseIncrementRefCount()pattern for proper wait state holder ownershipProcessIdandGetWaitState()now throwInvalidOperationExceptionwhen_waitStateHolderis null (previouslyProcessIdthrewPlatformNotSupportedException);GetWaitState()throwsPlatformNotSupportedExceptionfor non-child processes on UnixWaitForExit*tests including sync/async theories, signal reporting, timeout/kill behavior, non-child process handling, andProcess.SafeHandleinterop