Skip to content

Fix IBuildEngine9.RequestCores returning 0 causing ReleaseCores(0) to throw in WASM/Mono build tasks #125714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix IBuildEngine9.RequestCores returning 0 causing ReleaseCores(0) to throw in WASM/Mono build tasks #125714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a9a55
Initial plan
Copilot Mar 18, 2026
69865a5
Fix IBuildEngine9 RequestCores returning 0 causing ReleaseCores(0) to…
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/tasks/AotCompilerTask/MonoAOTCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,17 @@ private bool ExecuteInternal()
try
{
if (be9 is not null)
allowedParallelism = be9.RequestCores(allowedParallelism);
{
int requestedCores = be9.RequestCores(allowedParallelism);
if (requestedCores > 0)
allowedParallelism = requestedCores;
else
be9 = null;
}
Comment on lines +549 to +554
}
catch (NotImplementedException)
catch (Exception)
{
// RequestCores is not implemented in TaskHostFactory
// RequestCores is not implemented in TaskHostFactory, or IBuildEngine callbacks are not supported
be9 = null;
}
Comment on lines +556 to 560

Expand Down
12 changes: 9 additions & 3 deletions src/tasks/MonoTargetsTasks/EmitBundleTask/EmitBundleBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,17 @@ public override bool Execute()
try
{
if (be9 is not null)
allowedParallelism = be9.RequestCores(allowedParallelism);
{
int requestedCores = be9.RequestCores(allowedParallelism);
if (requestedCores > 0)
allowedParallelism = requestedCores;
else
be9 = null;
}
Comment on lines +162 to +167
}
catch (NotImplementedException)
catch (Exception)
{
// RequestCores is not implemented in TaskHostFactory
// RequestCores is not implemented in TaskHostFactory, or IBuildEngine callbacks are not supported
be9 = null;
}
Comment on lines +169 to 173

Expand Down
12 changes: 9 additions & 3 deletions src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,17 @@ public override bool Execute()
try
{
if (be9 is not null)
allowedParallelism = be9.RequestCores(allowedParallelism);
{
int requestedCores = be9.RequestCores(allowedParallelism);
if (requestedCores > 0)
allowedParallelism = requestedCores;
else
be9 = null;
}
Comment on lines +82 to +87
}
catch (NotImplementedException)
catch (Exception)
{
// RequestCores is not implemented in TaskHostFactory
// RequestCores is not implemented in TaskHostFactory, or IBuildEngine callbacks are not supported
be9 = null;
}
Comment on lines +89 to 93

Expand Down
12 changes: 9 additions & 3 deletions src/tasks/WasmAppBuilder/EmccCompile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,17 @@ private bool ExecuteActual()
try
{
if (be9 is not null)
allowedParallelism = be9.RequestCores(allowedParallelism);
{
int requestedCores = be9.RequestCores(allowedParallelism);
if (requestedCores > 0)
allowedParallelism = requestedCores;
else
be9 = null;
}
Comment on lines +139 to +144
}
catch (NotImplementedException)
catch (Exception)
{
// RequestCores is not implemented in TaskHostFactory
// RequestCores is not implemented in TaskHostFactory, or IBuildEngine callbacks are not supported
be9 = null;
}
Comment on lines +146 to 150

Expand Down
Loading