Skip to content

Enable NativeAOT library tests on Apple mobile platforms#125437

Draft
kotlarmilos wants to merge 81 commits intodotnet:mainfrom
kotlarmilos:enable-nativeaot-libs-tests-mobile
Draft

Enable NativeAOT library tests on Apple mobile platforms#125437
kotlarmilos wants to merge 81 commits intodotnet:mainfrom
kotlarmilos:enable-nativeaot-libs-tests-mobile

Conversation

@kotlarmilos
Copy link
Copy Markdown
Member

@kotlarmilos kotlarmilos commented Mar 11, 2026 •
edited
Loading

Description

Replace NativeAOT runtime test legs with library test legs on iOS/tvOS devices, iOS/tvOS simulators, and Mac Catalyst.

Depends on dotnet/xharness#1554

Fixes #81075

@kotlarmilos
Enable NativeAOT library tests on Apple mobile platforms
a5fb968 
Replace NativeAOT runtime test legs with library test legs on iOS/tvOS
devices, iOS/tvOS simulators, and Mac Catalyst. The runtime tests
(nativeaot/SmokeTests) provide minimal value on mobile since the compiler
doesn't meaningfully distinguish between iOS and macOS. Library tests
exercise OS-specific APIs (crypto, networking, etc.) that are the real
quality gate.

Changes:
- ioslike: remove NativeAOT runtime test leg, update existing library
  test leg to use dynamic smoke test arg
- ioslikesimulator: replace NativeAOT runtime test leg with library
  test leg, fix isiOSLikeSimulatorOnlyBuild parameter
- maccatalyst: replace both NativeAOT runtime test legs (regular +
  AppSandbox) with library test legs, fix coreclrContainsChange
  variable (was incorrectly using monoContainsChange)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 12:46
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Apple “extra platforms” CI legs to validate NativeAOT on iOS/tvOS devices, iOS/tvOS simulators, and Mac Catalyst by running libraries tests (via Helix) instead of the minimal NativeAOT runtime SmokeTests, improving OS-specific coverage (crypto/networking/globalization) on mobile.

Changes:

  • Switch NativeAOT Apple-mobile legs from runtime SmokeTests submission to eng/pipelines/libraries/helix.yml submission of libraries tests.
  • Use eng/pipelines/libraries/helix-queues-setup.yml and pass NeedsToBuildAppsOnHelix=true for the new legs.
  • Update naming/args to use $(_runSmokeTestsOnlyArg) and fix path-evaluation variable naming in affected legs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml Replaces NativeAOT runtime SmokeTests legs with libraries test legs (including App Sandbox variant) using libraries Helix templates/queues.
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml Replaces NativeAOT runtime SmokeTests on iOS/tvOS simulators with libraries tests using libraries Helix templates/queues.
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml Adjusts NativeAOT iOS/tvOS device leg to use $(_runSmokeTestsOnlyArg) for libraries tests and removes the old NativeAOT runtime SmokeTests device leg.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
@build-analysis build-analysis Bot mentioned this pull request Mar 11, 2026
Open
3 tasks
dotnet-maestro Bot and others added 5 commits March 12, 2026 10:30
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
fe0e141 
…60312.1

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26160.2 -> To Version 11.0.0-prerelease.26162.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
0a9ea0b 
…60312.3

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26160.2 -> To Version 11.0.0-prerelease.26162.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
1658ca5 
…60314.3

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26160.2 -> To Version 11.0.0-prerelease.26164.3
@kotlarmilos
Merge branch 'main' into enable-nativeaot-libs-tests-mobile
9e2a877
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
e9c07fe 
…60317.2

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26160.2 -> To Version 11.0.0-prerelease.26167.2
This was referenced Mar 17, 2026
Open
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
10f5e12 
…60318.1

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26160.2 -> To Version 11.0.0-prerelease.26168.1
@kotlarmilos kotlarmilos marked this pull request as draft March 18, 2026 12:57
@kotlarmilos
Merge remote-tracking branch 'upstream/darc-main-98c14788-b6c2-47d8-8…
98a831a 
…bb6-53258cb4f260' into enable-nativeaot-libs-tests-mobile
Copilot AI review requested due to automatic review settings March 18, 2026 13:02
Copilot AI reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 11/11 changed files
  • Comments generated: 0 new

kotlarmilos and others added 3 commits April 30, 2026 13:38
@kotlarmilos
Remove explanatory comments and IsNativeAot ActiveIssue annotations
7fb4f8d 
The IsNativeAot ActiveIssue lines are reverted per request — the 3 tests
(ModuleTests.Name, ModuleTests.FullyQualifiedName, DoubleTests.ParsePatterns)
will now fail again on the NativeAOT smoke leg.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Drop AppleBuildDependsOn rewrite; rely on _AotCompileTargetName override
cbca90c 
The Directory.Build.props auto-import already builds the chain, and the
proxy header at line 10 prepends the Helix-specific targets and appends
_AfterAppleBuildOnHelix. Setting _AotCompileTargetName=_NoOpNativeAotCompileOnHelix
is enough — the default chain expands $(_AotCompileTargetName) to it. The
remaining default targets (_ScanAssembliesDecideLightweightMarshaler,
$(_ProcessRuntimeComponentsForLibraryMode), _BuildNativeLibrary) are gated
to no-op for NativeAOT.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Consolidate NativeAOT-on-Helix proxy bits behind _NativeAotLibraryTes…
ff6997f 
…tOnHelix

- Single shorthand property gates all NativeAOT library-test additions.
- Group the related PropertyGroup, ItemGroup, and Target adjacently.
- Rename _NoOpNativeAotCompileOnHelix to _StageNativeAotLinkInputsOnHelix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 1

Comment thread src/libraries/Common/tests/AppleTestRunner/AppleTestRunner.cs
kotlarmilos and others added 2 commits April 30, 2026 17:38
@kotlarmilos
Fix NativeAOT_Smoke regression: rewire AppleBuildDependsOn
bcddb86 
AppleBuild.props eagerly expands $(_AotCompileTargetName) when defining
AppleBuildDependsOn. The override of _AotCompileTargetName in the proxy
therefore never reaches the chain, leaving _AppleNativeAotCompile (which
depends on IlcCompile) in the dependency list. ILC then runs on Helix
and crashes because the host build only emitted lib<Name>.a, not a .dll.

Replace _AppleNativeAotCompile with _StageNativeAotLinkInputsOnHelix in
AppleBuildDependsOn directly via String.Replace. This restores the chain
shape that worked in build 1401875.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Remove AppleBuildDependsOn rewrite comment
67eca00 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 1

Comment thread eng/testing/tests.ioslike.targets
kotlarmilos and others added 2 commits April 30, 2026 20:26
@kotlarmilos
Restore hand-written AppleBuildDependsOn chain
37d892e 
The String.Replace approach produced a multi-line value that MSBuild
collapsed into a single target name (MSB4057). Use the explicit
single-line chain that previously worked in build 1401875.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Skip 3 System.Runtime.Tests failing on NativeAOT Apple mobile
db92fd4 
Tracked under dotnet#127786.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented May 5, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 5, 2026

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos and others added 2 commits May 5, 2026 16:28
@kotlarmilos
Run full library test set on NativeAOT Apple mobile
e2c4cf8 
Drop /p:RunSmokeTestsOnly=true from the four NativeAOT Apple-mobile legs
(ios-arm64, iossimulator, maccatalyst, maccatalyst AppSandbox) and rename
the legs from AllSubsets_NativeAOT_Smoke to AllSubsets_NativeAOT.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Apply DirectPInvoke=__Internal to all NativeAOT proxy paths
b99d2d4 
Functional tests with custom Main (IncludesTestRunner=false) PInvoke into
mono_ios_set_summary in the AppleAppBuilder-generated objc main. They run
ILC on Helix via the proxy, so the proxy must emit DirectPInvoke __Internal
for them too — not just for library tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented May 5, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 5, 2026

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 5, 2026
Open
Open
@kotlarmilos
Scope NativeAOT Apple-mobile additions to .NETCoreApp TFM
4eae8d6 
Multi-targeted test projects (e.g. Microsoft.Extensions.Hosting.Abstractions.Tests
targeting net481+net11.0) hit NU1202 because Microsoft.DotNet.XHarness.TestRunners.Xunit
isn't compatible with .NETFramework. The smoke set (System.Runtime.Tests) is
single-TFM so the issue surfaced only when the full library test set was enabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos kotlarmilos mentioned this pull request May 6, 2026
Closed
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented May 6, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 6, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented May 7, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis Bot mentioned this pull request May 7, 2026
Open
@kotlarmilos
Fix NativeAOT build errors for full Apple-mobile test set
805311c 
- AppleTestRunner.GetTestAssemblies: suppress IL2026 since the
  Assembly.LoadFrom branch is unreachable on NativeAOT (s_testAssemblies
  is populated from AppDomain.CurrentDomain.GetAssemblies()).
- src/libraries/tests.proj: exclude the ReflectionInvokeEmit and
  ReflectionInvokeInterpreted tests on Apple-mobile NativeAOT. They use
  runtimeconfig.template.json which PublishAot rejects, the Emit path is
  not supported on NativeAOT, and the interpreted path is already the
  NativeAOT default.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented May 7, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis Bot mentioned this pull request May 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@matouskozak matouskozak matouskozak approved these changes

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@davidnguyen-tech davidnguyen-tech Awaiting requested review from davidnguyen-tech

Copilot code review Copilot Awaiting requested review from Copilot

Assignees

@kotlarmilos kotlarmilos

Labels

area-Infrastructure-coreclr os-ios Apple iOS

Projects

Runtime Infra
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable building/running libraries tests on iOS simulator and device with NativeAOT

7 participants

@kotlarmilos @MichalStrehovsky @steveisok @jkoritzinsky @jkotas @matouskozak