Re-enable symbol stripping for Apple platforms by kotlarmilos · Pull Request #124266 · dotnet/runtime

kotlarmilos · 2026-02-11T12:34:47Z

Description

This PR re-enables symbol stripping for Apple platforms that was disabled as a workaround in #123687.

Changes

Re-enable stripping in ILCompiler_publish.csproj, crossgen2_publish.csproj, ilasm.csproj, and XUnitLogChecker.csproj by removing the StripSymbols=false workaround.
Handle non-fatal dsymutil warnings by adding IgnoreStandardErrorWarningFormat="true" to the dsymutil <Exec> tasks in Microsoft.NETCore.Native.targets, Microsoft.NET.CrossGen.targets, and native-library.targets. Apple's pre-built Swift runtime static libraries (swiftCore, swiftFoundation) contain DWARF debug info with -gmodules references to .pcm module cache files that only existed on Apple's build machines. dsymutil outputs error: messages for these missing files but exits with code 0 (non-fatal). Without this flag, MSBuild's <Exec> task parses the output for error: patterns and incorrectly counts them as build errors. Non-zero exit codes (real failures) are still caught.
Fix Apple platform detection in eng/toolAot.targets for NativeSymbolExt and DsymUtilOptions. The _IsApplePlatform property from the NativeAOT NuGet package is not available at this evaluation point, so use PortableOS instead. Broadened the condition to UseNativeAotForComponents (from AotOrSingleFile and UseNativeAotForComponents) to cover components like XUnitLogChecker that set PublishAot directly.

Copilot

Pull request overview

This PR re-enables symbol stripping for Apple platforms by removing a temporary workaround that was added in PR #123386. The workaround disabled symbol stripping (StripSymbols=false) to avoid dsymutil module cache errors that occurred when Swift code was compiled with -g (full debug info). Now that the underlying Swift compilation has been fixed to use -gline-tables-only instead, symbol stripping can be safely re-enabled.

Changes:

Removes StripSymbols=false workaround from three .csproj files (ILCompiler, crossgen2, and XUnitLogChecker)
Adds symbol stripping logic to the CrossGen2 test script for Apple mobile runtime tests

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/coreclr/tools/aot/ILCompiler/ILCompiler_publish.csproj	Removes the StripSymbols=false workaround, allowing default symbol stripping behavior to apply
src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj	Removes the StripSymbols=false workaround, allowing default symbol stripping behavior to apply
src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj	Removes the StripSymbols=false workaround, allowing default symbol stripping behavior to apply
src/tests/Common/CLRTest.CrossGen.targets	Adds symbol stripping command after linking for Mach-O format outputs when StripSymbols is true

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

src/tests/Common/CLRTest.CrossGen.targets

kotlarmilos · 2026-03-02T08:51:12Z

The macOS jobs are still reporting missing module cache files (.pcm).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

src/tests/Common/CLRTest.CrossGen.targets

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

The NativeAOT SDK targets invoke dsymutil during symbol stripping. Apple's pre-built Swift runtime static libraries contain -gmodules debug info with references to .pcm module cache files that don't exist on build machines. dsymutil outputs 'error:' for these missing files but exits 0 (non-fatal). MSBuild's Exec task parses the output and treats them as build errors. The tool AOT publish (ILCompiler, crossgen2, XUnitLogChecker) uses the SDK's NativeAOT targets, not the source-tree targets, so the IgnoreStandardError WarningFormat fix in Microsoft.NETCore.Native.targets doesn't apply here. Redirecting dsymutil stderr via DsymUtilOptions suppresses the non-fatal warnings while preserving exit code based error detection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… publishing

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

src/tools/ilasm/src/ilasm/ilasm.csproj

eng/toolAot.targets

dsymutil outputs 'error: <path>.pcm: No such file or directory' messages to stdout (not stderr) when processing binaries linked against Apple's Swift runtime static libraries. The previous 2>/dev/null only suppressed stderr, leaving stdout errors visible to MSBuild's error pattern matching. Change to >/dev/null 2>&1 to suppress both streams since dsymutil's diagnostic output is not needed (the .dwarf file is the actual output). This fix applies regardless of whether local or NuGet package NativeAOT targets are used, since DsymUtilOptions is set in eng/toolAot.targets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move the Apple platform settings (DsymUtilOptions, NativeSymbolExt) out of the AotOrSingleFile condition gate into a UseNativeAotForComponents-only PropertyGroup. This ensures projects like XUnitLogChecker that set PublishAot directly (without AotOrSingleFile) also get the dsymutil stdout suppression needed to avoid non-fatal PCM error messages breaking the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

eng/toolAot.targets

- Revert -gline-tables-only from src/native/libs/CMakeLists.txt - Revert -gnone back to -gline-tables-only for Swift compilation - Revert CLRTest.CrossGen.targets stripping change - Remove >/dev/null 2>&1 from DsymUtilOptions (redundant with IgnoreStandardErrorWarningFormat) - Consolidate PropertyGroups in eng/toolAot.targets Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-20T09:18:52Z

eng/toolAot.targets

-  <PropertyGroup Condition="'$(AotOrSingleFile)' == 'true' and '$(UseNativeAotForComponents)' == 'true'">
-    <PublishAot>true</PublishAot>
+  <PropertyGroup Condition="'$(UseNativeAotForComponents)' == 'true'">
+    <PublishAot Condition="'$(AotOrSingleFile)' == 'true'" >true</PublishAot>


There is an extra space before the closing angle bracket in the <PublishAot ...> element (... == 'true'" >true). This is inconsistent with the surrounding XML formatting and should be removed to keep the file tidy and avoid noisy diffs in future edits.

Suggested change

<PublishAot Condition="'$(AotOrSingleFile)' == 'true'" >true</PublishAot>

<PublishAot Condition="'$(AotOrSingleFile)' == 'true'">true</PublishAot>

kotlarmilos added 3 commits February 11, 2026 13:25

Enable symbol stripping for Apple platforms

8170097

Revert changes

5925853

Enable stripping in crossgen2_publish

2145b8c

kotlarmilos requested review from Copilot, jkoritzinsky and steveisok February 11, 2026 12:34

github-actions bot added the area-crossgen2-coreclr label Feb 11, 2026

dotnet-policy-service bot assigned kotlarmilos Feb 11, 2026

Copilot started reviewing on behalf of kotlarmilos February 11, 2026 12:35 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

build-analysis bot mentioned this pull request Feb 11, 2026

crossgen2 failing on Linux Arm32 intermittently #124007

Closed

Merge branch 'main' into bugfix/enable-strip-symbols

12f4bb4

build-analysis bot mentioned this pull request Feb 18, 2026

[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526

Open

Merge branch 'main' into bugfix/enable-strip-symbols

cc0629e

Copilot AI review requested due to automatic review settings February 27, 2026 09:21

Copilot started reviewing on behalf of kotlarmilos February 27, 2026 09:22 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

src/tests/Common/CLRTest.CrossGen.targets Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Feb 27, 2026

Android WebSocket failure #121518

Open

jkoritzinsky approved these changes Feb 28, 2026

View reviewed changes

Merge branch 'main' into bugfix/enable-strip-symbols

ed67ff4

build-analysis bot mentioned this pull request Mar 2, 2026

Error while retrieving client Settings for PipelineArtifact. HttpRequestException: nodename nor servname provided, or not known (vsblobprodcus3.vsblob.visualstudio.com:443) #96798

Open

Merge branch 'main' into bugfix/enable-strip-symbols

ca0bba7

Copilot AI review requested due to automatic review settings March 4, 2026 13:54

Copilot started reviewing on behalf of kotlarmilos March 4, 2026 13:56 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

src/tests/Common/CLRTest.CrossGen.targets Outdated Show resolved Hide resolved

This was referenced Mar 4, 2026

System.IO.Tests.Directory_Create_Tests.FileSystemWatcher_Directory_Create_InNestedDirectory fails with "Created event did not occur as expected" #103630

Open

iOS tests failing with WORKLOAD TIMED OUT - Killing user command. #108103

Open

Merge branch 'main' into bugfix/enable-strip-symbols

b9866fb

build-analysis bot mentioned this pull request Mar 11, 2026

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

Copilot AI review requested due to automatic review settings March 16, 2026 11:40

kotlarmilos requested a review from MichalStrehovsky as a code owner March 16, 2026 11:40

Copilot started reviewing on behalf of kotlarmilos March 16, 2026 11:42 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

This was referenced Mar 16, 2026

[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603

Open

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

kotlarmilos and others added 2 commits March 16, 2026 17:39

Refactor Apple platform detection and symbol stripping options in AOT…

a3583b7

… publishing

Copilot AI review requested due to automatic review settings March 17, 2026 16:28

Copilot started reviewing on behalf of kotlarmilos March 17, 2026 16:30 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

src/tools/ilasm/src/ilasm/ilasm.csproj Show resolved Hide resolved

eng/toolAot.targets Outdated Show resolved Hide resolved

kotlarmilos and others added 2 commits March 18, 2026 10:53

Copilot AI review requested due to automatic review settings March 18, 2026 12:52

Copilot started reviewing on behalf of kotlarmilos March 18, 2026 12:52 View session

kotlarmilos marked this pull request as draft March 18, 2026 12:53

Copilot AI reviewed Mar 18, 2026

View reviewed changes

eng/toolAot.targets Outdated Show resolved Hide resolved

Merge branch 'main' into bugfix/enable-strip-symbols

1e66d6b

Copilot AI review requested due to automatic review settings March 20, 2026 09:15

Copilot started reviewing on behalf of kotlarmilos March 20, 2026 09:16 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable symbol stripping for Apple platforms#124266

Re-enable symbol stripping for Apple platforms#124266
kotlarmilos wants to merge 17 commits intodotnet:mainfrom
kotlarmilos:bugfix/enable-strip-symbols

kotlarmilos commented Feb 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

kotlarmilos commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<PublishAot Condition="'$(AotOrSingleFile)' == 'true'" >true</PublishAot>
	<PublishAot Condition="'$(AotOrSingleFile)' == 'true'">true</PublishAot>

Conversation

kotlarmilos commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

kotlarmilos commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kotlarmilos commented Feb 11, 2026 •

edited

Loading