Skip to content

Fix NativeAOT publish including satellite assemblies despite embedding them #124192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbomer merged 5 commits into from
Mar 24, 2026
Merged

Fix NativeAOT publish including satellite assemblies despite embedding them #124192

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1bca05
Initial plan
Copilot Feb 9, 2026
1801e3b
Add fix to remove satellite assemblies from publish folder and create…
Copilot Feb 9, 2026
3feb4a7
Remove test from runtime repo per review feedback
Copilot Feb 10, 2026
875ec0e
Merge remote-tracking branch 'origin/main' into satellite
sbomer Mar 16, 2026
58612b9
Merge remote-tracking branch 'origin/main' into satellite
sbomer Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<ItemGroup>
<IntermediateAssembly Remove="@(IntermediateAssembly)" />
<IntermediateAssembly Include="$(NativeBinary)" />
<IntermediateSatelliteAssembliesWithTargetPath Remove="@(IntermediateSatelliteAssembliesWithTargetPath)" />
Comment thread
sbomer marked this conversation as resolved.
Outdated
</ItemGroup>
</Target>

Expand Down
66 changes: 66 additions & 0 deletions src/tests/nativeaot/SmokeTests/SatelliteAssemblies/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Globalization;
using System.IO;
using System.Reflection;
using System.Resources;

class Program
{
static int Main(string[] args)
{
// Test that we can access resources
ResourceManager rm = new ResourceManager("SatelliteAssemblies.Strings", Assembly.GetExecutingAssembly());

// Test English (default)
string englishGreeting = rm.GetString("Greeting", CultureInfo.InvariantCulture);
Console.WriteLine($"English: {englishGreeting}");
if (englishGreeting != "Hello, World!")
{
Console.WriteLine("ERROR: Expected 'Hello, World!' for English");
return 1;
}

// Test Spanish
string spanishGreeting = rm.GetString("Greeting", new CultureInfo("es"));
Console.WriteLine($"Spanish: {spanishGreeting}");
if (spanishGreeting != "¡Hola, Mundo!")
{
Console.WriteLine("ERROR: Expected '¡Hola, Mundo!' for Spanish");
return 1;
}

// Verify that satellite assemblies are NOT in the publish directory
// when this is published with PublishAot
string exePath = Environment.ProcessPath ?? Assembly.GetExecutingAssembly().Location;
string publishDir = Path.GetDirectoryName(exePath);

if (string.IsNullOrEmpty(publishDir))
{
Console.WriteLine("ERROR: Could not determine publish directory");
return 1;
}

Comment thread
sbomer marked this conversation as resolved.
Outdated
// Check that the 'es' subdirectory does not exist in publish output
string esDir = Path.Combine(publishDir, "es");
if (Directory.Exists(esDir))
{
Console.WriteLine($"ERROR: Satellite assembly directory exists: {esDir}");
Console.WriteLine("Satellite assemblies should be embedded in the native binary, not copied to publish folder");

// List what's in there for diagnostic purposes
var files = Directory.GetFiles(esDir);
foreach (var file in files)
{
Console.WriteLine($" Found: {Path.GetFileName(file)}");
}

return 1;
}

Console.WriteLine("SUCCESS: Resources are accessible and no satellite assembly folders in publish directory");
return 100;
}
}
13 changes: 13 additions & 0 deletions src/tests/nativeaot/SmokeTests/SatelliteAssemblies/SatelliteAssemblies.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<CLRTestPriority>0</CLRTestPriority>
</PropertyGroup>

<ItemGroup>
<EmbeddedResource Include="Strings.resx" />
<EmbeddedResource Include="Strings.es.resx" />
<Compile Include="Strings.Designer.cs" />
<Compile Include="Program.cs" />
</ItemGroup>
</Project>
28 changes: 28 additions & 0 deletions src/tests/nativeaot/SmokeTests/SatelliteAssemblies/Strings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 64 additions & 0 deletions src/tests/nativeaot/SmokeTests/SatelliteAssemblies/Strings.es.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<?xml version="1.0" encoding="utf-8"?>
<root>
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
<xsd:element name="root" msdata:IsDataSet="true">
<xsd:complexType>
<xsd:choice maxOccurs="unbounded">
<xsd:element name="metadata">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" />
</xsd:sequence>
<xsd:attribute name="name" use="required" type="xsd:string" />
<xsd:attribute name="type" type="xsd:string" />
<xsd:attribute name="mimetype" type="xsd:string" />
<xsd:attribute ref="xml:space" />
</xsd:complexType>
</xsd:element>
<xsd:element name="assembly">
<xsd:complexType>
<xsd:attribute name="alias" type="xsd:string" />
<xsd:attribute name="name" type="xsd:string" />
</xsd:complexType>
</xsd:element>
<xsd:element name="data">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
<xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
<xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
<xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
<xsd:attribute ref="xml:space" />
</xsd:complexType>
</xsd:element>
<xsd:element name="resheader">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" />
</xsd:complexType>
</xsd:element>
</xsd:choice>
</xsd:complexType>
</xsd:element>
</xsd:schema>
<resheader name="resmimetype">
<value>text/microsoft-resx</value>
</resheader>
<resheader name="version">
<value>2.0</value>
</resheader>
<resheader name="reader">
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="Greeting" xml:space="preserve">
<value>¡Hola, Mundo!</value>
</data>
</root>
64 changes: 64 additions & 0 deletions src/tests/nativeaot/SmokeTests/SatelliteAssemblies/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<?xml version="1.0" encoding="utf-8"?>
<root>
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
<xsd:element name="root" msdata:IsDataSet="true">
<xsd:complexType>
<xsd:choice maxOccurs="unbounded">
<xsd:element name="metadata">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" />
</xsd:sequence>
<xsd:attribute name="name" use="required" type="xsd:string" />
<xsd:attribute name="type" type="xsd:string" />
<xsd:attribute name="mimetype" type="xsd:string" />
<xsd:attribute ref="xml:space" />
</xsd:complexType>
</xsd:element>
<xsd:element name="assembly">
<xsd:complexType>
<xsd:attribute name="alias" type="xsd:string" />
<xsd:attribute name="name" type="xsd:string" />
</xsd:complexType>
</xsd:element>
<xsd:element name="data">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
<xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
<xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
<xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
<xsd:attribute ref="xml:space" />
</xsd:complexType>
</xsd:element>
<xsd:element name="resheader">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" />
</xsd:complexType>
</xsd:element>
</xsd:choice>
</xsd:complexType>
</xsd:element>
</xsd:schema>
<resheader name="resmimetype">
<value>text/microsoft-resx</value>
</resheader>
<resheader name="version">
<value>2.0</value>
</resheader>
<resheader name="reader">
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="Greeting" xml:space="preserve">
<value>Hello, World!</value>
</data>
</root>
Loading