-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix IndexOfAnyInRange inconsistent behavior with invalid ranges across vectorized/scalar paths #123365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix IndexOfAnyInRange inconsistent behavior with invalid ranges across vectorized/scalar paths #123365
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b5a32e6
Initial plan
Copilot 899e2fb
Add fix and tests for invalid range in IndexOfAnyInRange methods
Copilot b3053c3
Fix invalid range check for IComparable path (non-intrinsics)
Copilot 2304cfa
Move invalid range checks to public entry points in MemoryExtensions
Copilot 7c38104
Convert InvalidRange test to Theory with edge cases and negative values
Copilot 8390cb3
Use span.IsEmpty instead of span.Length > 0 for readability
Copilot 058b758
Fix test failures by removing overflowing test values
Copilot efc304d
Merge branch 'main' into copilot/fix-indexofanyinrange-behavior
stephentoub 2e77c57
Update src/libraries/System.Private.CoreLib/src/System/MemoryExtensio…
stephentoub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.